Remove EventHandler class and all references

freemo commented

2026-03-15 23:08:56 +00:00

Owner

Metadata

Commit Message: refactor(core): remove deprecated EventHandler class and all references
Branch: feature/m2-remove-event-handler

Background and Context

With combat using CombatService and Reacts using PriorityQueue, EventHandler has no consumers.

Acceptance Criteria

EventHandler class deleted
@event_handler removed from Manager
event_queue references removed
No reflection dispatch remains
All tests pass

Subtasks

Delete lib/aethyr/core/components/event_handler.rb
Remove @event_handler from Manager
Remove event_queue references
Grep for remaining event_handler references
Update test step definitions
Tests (Cucumber): Full game lifecycle verification
Run bundle exec rake unit and bundle exec rake integration, fix any failures
Update docs/developer/architecture.md
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber Integration): Add integration feature in tests/integration/ verifying server boots and operates correctly with EventHandler class removed.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when all subtasks are completed, commit created with prescribed message on prescribed branch, PR submitted, reviewed, and merged.

## Metadata - **Commit Message:** `refactor(core): remove deprecated EventHandler class and all references` - **Branch:** `feature/m2-remove-event-handler` ## Background and Context With combat using CombatService and Reacts using PriorityQueue, EventHandler has no consumers. ## Acceptance Criteria - `EventHandler` class deleted - `@event_handler` removed from Manager - `event_queue` references removed - No reflection dispatch remains - All tests pass ## Subtasks - [ ] Delete `lib/aethyr/core/components/event_handler.rb` - [ ] Remove `@event_handler` from Manager - [ ] Remove `event_queue` references - [ ] Grep for remaining `event_handler` references - [ ] Update test step definitions - [ ] Tests (Cucumber): Full game lifecycle verification - [ ] Run `bundle exec rake unit` and `bundle exec rake integration`, fix any failures - [ ] Update `docs/developer/architecture.md` - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` verifying server boots and operates correctly with EventHandler class removed. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when all subtasks are completed, commit created with prescribed message on prescribed branch, PR submitted, reviewed, and merged.