Replace alert() calls with Wisper events in core objects

freemo commented

2026-03-15 23:08:54 +00:00

Owner

Metadata

Commit Message: refactor(events): replace .alert() dispatch with Wisper events in core objects
Branch: feature/m1-sunset-alert

Background and Context

alert() distributes Event objects via direct method calls. Must be converted to Wisper broadcasts.

Acceptance Criteria

GameObject#run tick uses broadcast(:tick) instead of alert(Event.new(...))
Container propagates via Wisper subscription
Mobile balance/action events use Wisper
Experiments sandbox uses Wisper events
NPC reactions still work

Subtasks

Replace alert() in GameObject#run with broadcast(:tick, ...)
Replace Container#alert with Wisper-based propagation
Replace alert() in Mobile with Wisper broadcasts
Replace alert() in experiments/sandbox.rb
Update Reacts trait to subscribe to Wisper events
Tests (Cucumber): Verify NPC tick actions fire
Tests (Cucumber): Verify mobile balance reactions work
Run bundle exec rake unit, fix any failures
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber Integration): Add integration feature in tests/integration/ verifying no remaining alert() calls exist in core objects.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when all subtasks are completed, commit created with prescribed message on prescribed branch, PR submitted, reviewed, and merged.

## Metadata - **Commit Message:** `refactor(events): replace .alert() dispatch with Wisper events in core objects` - **Branch:** `feature/m1-sunset-alert` ## Background and Context `alert()` distributes `Event` objects via direct method calls. Must be converted to Wisper broadcasts. ## Acceptance Criteria - `GameObject#run` tick uses `broadcast(:tick)` instead of `alert(Event.new(...))` - `Container` propagates via Wisper subscription - `Mobile` balance/action events use Wisper - Experiments sandbox uses Wisper events - NPC reactions still work ## Subtasks - [ ] Replace `alert()` in `GameObject#run` with `broadcast(:tick, ...)` - [ ] Replace `Container#alert` with Wisper-based propagation - [ ] Replace `alert()` in `Mobile` with Wisper broadcasts - [ ] Replace `alert()` in `experiments/sandbox.rb` - [ ] Update `Reacts` trait to subscribe to Wisper events - [ ] Tests (Cucumber): Verify NPC tick actions fire - [ ] Tests (Cucumber): Verify mobile balance reactions work - [ ] Run `bundle exec rake unit`, fix any failures - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` verifying no remaining alert() calls exist in core objects. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when all subtasks are completed, commit created with prescribed message on prescribed branch, PR submitted, reviewed, and merged.