Epic: EventHandler Deprecation and Removal #192

Open
opened 2026-03-15 23:08:54 +00:00 by freemo · 0 comments
Owner

Background and Context

The EventHandler processes events using reflection: Module.const_get(event.type).send(event.action, ...). It is retained only for combat delayed events (punch_result, slash_result, kick_result) and NPC Reacts action sequences. The spec has a 4-phase deprecation plan: freeze, extract CombatService, migrate Reacts, remove.

Demonstrable Outcome

EventHandler class deleted. Combat uses CombatService. Reacts uses PriorityQueue.

Acceptance Criteria

  • EventHandler class deleted
  • @event_handler removed from Manager
  • Combat delayed events use CombatService
  • Reacts NPC sequences use PriorityQueue
## Background and Context The `EventHandler` processes events using reflection: `Module.const_get(event.type).send(event.action, ...)`. It is retained only for combat delayed events (punch_result, slash_result, kick_result) and NPC Reacts action sequences. The spec has a 4-phase deprecation plan: freeze, extract CombatService, migrate Reacts, remove. ## Demonstrable Outcome `EventHandler` class deleted. Combat uses `CombatService`. Reacts uses `PriorityQueue`. ## Acceptance Criteria - EventHandler class deleted - `@event_handler` removed from Manager - Combat delayed events use CombatService - Reacts NPC sequences use PriorityQueue
freemo added this to the v1.2.0 milestone 2026-03-15 23:19:52 +00:00
freemo modified the milestone from v1.2.0 to v1.0.0 2026-03-16 00:27:55 +00:00
freemo self-assigned this 2026-03-16 01:26:59 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference: aethyr/Aethyr#192
No description provided.