Extract CombatService from Combat module with explicit method dispatch

freemo commented

2026-03-15 23:08:55 +00:00

Owner

Metadata

Commit Message: refactor(combat): extract CombatService from Combat module with explicit dispatch
Branch: feature/m2-combat-service

Background and Context

The Combat module's delayed event results are dispatched via EventHandler reflection. A CombatService class replaces this with explicit methods.

Acceptance Criteria

CombatService with punch_result, slash_result, kick_result methods
Combat future events dispatched via CombatService, not reflection
Combat.future_event submits to PriorityQueue
All combat tests pass

Subtasks

Create CombatService class
Move result methods from Combat module
Refactor Combat.future_event for PriorityQueue
Tests (Cucumber): Verify combat actions resolve correctly
Tests (Cucumber): Verify delayed events fire at correct time
Run bundle exec rake unit, fix any failures
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber Integration): Add integration feature in tests/integration/ verifying CombatService handles delayed combat events without EventHandler.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when all subtasks are completed, commit created with prescribed message on prescribed branch, PR submitted, reviewed, and merged.

## Metadata - **Commit Message:** `refactor(combat): extract CombatService from Combat module with explicit dispatch` - **Branch:** `feature/m2-combat-service` ## Background and Context The `Combat` module's delayed event results are dispatched via EventHandler reflection. A `CombatService` class replaces this with explicit methods. ## Acceptance Criteria - `CombatService` with `punch_result`, `slash_result`, `kick_result` methods - Combat future events dispatched via CombatService, not reflection - `Combat.future_event` submits to PriorityQueue - All combat tests pass ## Subtasks - [ ] Create `CombatService` class - [ ] Move result methods from Combat module - [ ] Refactor `Combat.future_event` for PriorityQueue - [ ] Tests (Cucumber): Verify combat actions resolve correctly - [ ] Tests (Cucumber): Verify delayed events fire at correct time - [ ] Run `bundle exec rake unit`, fix any failures - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` verifying CombatService handles delayed combat events without EventHandler. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when all subtasks are completed, commit created with prescribed message on prescribed branch, PR submitted, reviewed, and merged.