Migrate Reacts NPC action_sequence from EventHandler to PriorityQueue

freemo commented

2026-03-15 23:08:56 +00:00

Owner

Metadata

Commit Message: refactor(npc): migrate Reacts action_sequence from EventHandler queue to PriorityQueue
Branch: feature/m2-reacts-priority-queue

Background and Context

The Reacts trait's action_sequence chains NPC events via EventHandler queue. Must use Manager#submit_action(action, wait: delay) instead.

Acceptance Criteria

Reacts#action_sequence uses PriorityQueue with wait: delays
No NPC events flow through EventHandler
All NPC reaction tests pass
Tutorial helper NPC functions correctly

Subtasks

Refactor Reacts#action_sequence for $manager.submit_action
Remove EventHandler queue usage from Reacts
Tests (Cucumber): Verify NPC sequences execute in order
Tests (Cucumber): Verify delayed actions fire correctly
Run bundle exec rake unit, fix any failures
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber Integration): Add integration feature in tests/integration/ verifying NPC action_sequence reactions execute via PriorityQueue instead of EventHandler.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when all subtasks are completed, commit created with prescribed message on prescribed branch, PR submitted, reviewed, and merged.

## Metadata - **Commit Message:** `refactor(npc): migrate Reacts action_sequence from EventHandler queue to PriorityQueue` - **Branch:** `feature/m2-reacts-priority-queue` ## Background and Context The `Reacts` trait's `action_sequence` chains NPC events via EventHandler queue. Must use `Manager#submit_action(action, wait: delay)` instead. ## Acceptance Criteria - `Reacts#action_sequence` uses PriorityQueue with `wait:` delays - No NPC events flow through EventHandler - All NPC reaction tests pass - Tutorial helper NPC functions correctly ## Subtasks - [ ] Refactor `Reacts#action_sequence` for `$manager.submit_action` - [ ] Remove EventHandler queue usage from Reacts - [ ] Tests (Cucumber): Verify NPC sequences execute in order - [ ] Tests (Cucumber): Verify delayed actions fire correctly - [ ] Run `bundle exec rake unit`, fix any failures - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` verifying NPC action_sequence reactions execute via PriorityQueue instead of EventHandler. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when all subtasks are completed, commit created with prescribed message on prescribed branch, PR submitted, reviewed, and merged.