Implement Martial Arts terminal branch requiring Kick 5 and Grapple 5 #232

New issue

Open

opened 2026-03-16 01:40:17 +00:00 by freemo · 0 comments

freemo commented

2026-03-16 01:40:17 +00:00

Owner

Metadata

Key	Value
Parent Epic	#224 — Combat Discipline Tree
Legendary	#198 — Character Progression & Skills
Branch	`feature/m4-martial-arts-terminal-branch`
Commit Message	`feat(skills): implement Martial Arts terminal branch requiring Kick 5 and Grapple 5`
Points	3
Priority	High
MoSCoW	Should Have

Background and Context

Martial Arts is the terminal (capstone) node in the Combat discipline tree. It represents the pinnacle of unarmed combat mastery, requiring a player to have achieved high proficiency in both Kick and Grapple — the two tier-2 branches of the Unarmed specialization. This convergence node requires multiple prerequisites, making it the first multi-prerequisite node in the tree.

The Martial Arts node demonstrates the system's ability to handle nodes that depend on multiple prerequisites at specific levels. This pattern will be reused in other discipline trees for their own terminal/convergence nodes.

Expected Behavior

YAML Definition added to conf/skill_trees.yaml:

combat_terminal:
  martial_arts:
    name: Martial Arts
    discipline: combat
    description: "The ultimate synthesis of kicking and grappling arts into a unified martial discipline. Masters of Martial Arts can chain kicks, throws, and locks into devastating combinations."
    tier: 3
    prerequisites:
      - name: kick
        level: 5
      - name: grapple
        level: 5
    xp_required: 10000
    max_level: 10

Multi-Prerequisite Validation:
- check_unlockable(player) must verify BOTH prerequisites are met (Kick >= 5 AND Grapple >= 5).
- A player with Kick 5 but Grapple 4 should NOT see Martial Arts as unlockable.
- A player with Kick 4 and Grapple 5 should NOT see Martial Arts as unlockable.
- Only when both are at level 5+ should Martial Arts appear as unlockable.
Tree Structure:
- children_of("kick") should include Martial Arts.
- children_of("grapple") should include Martial Arts.
- list_by_discipline(:combat) returns 10 nodes across tiers 0-3.
- Martial Arts is the only tier-3 node in the combat discipline.

Full Combat Tree Hierarchy:

Combat (tier 0)
├── Swordplay (tier 1) → Finesse, Power (tier 2)
├── Shield (tier 1) → Guard (tier 2)
└── Unarmed (tier 1) → Kick, Grapple (tier 2) → Martial Arts (tier 3)

Acceptance Criteria

Martial Arts node is defined in conf/skill_trees.yaml at tier 3.
Martial Arts requires both kick at level 5 AND grapple at level 5.
check_unlockable only lists Martial Arts when BOTH prerequisites are met.
children_of("kick") includes Martial Arts.
children_of("grapple") includes Martial Arts.
list_by_discipline(:combat) returns 10 nodes across 4 tiers (0-3).
validate! passes with the complete combat tree.
Multi-prerequisite logic is tested with all combinations (both met, one met, neither met).

Subtasks

Add Martial Arts node definition to conf/skill_trees.yaml under combat terminal.
Verify check_unlockable handles multi-prerequisite AND logic correctly.
Test with Kick=5, Grapple=4 (should NOT unlock).
Test with Kick=4, Grapple=5 (should NOT unlock).
Test with Kick=5, Grapple=5 (should unlock).
Verify children_of("kick") and children_of("grapple") both include Martial Arts.
Verify full combat tree has 10 nodes across 4 tiers.
Run validate! on the complete combat tree.
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber): Add tests/unit/martial_arts_terminal.feature covering multi-prerequisite AND logic, partial prerequisite failure, both prerequisites met, children_of for kick and grapple, full combat tree enumeration, tree validation.
Tests (Cucumber Integration): Add integration feature in tests/integration/ for Martial Arts terminal node with multi-prerequisite validation.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.

## Metadata | Key | Value | |-----|-------| | **Parent Epic** | #224 — Combat Discipline Tree | | **Legendary** | #198 — Character Progression & Skills | | **Branch** | `feature/m4-martial-arts-terminal-branch` | | **Commit Message** | `feat(skills): implement Martial Arts terminal branch requiring Kick 5 and Grapple 5` | | **Points** | 3 | | **Priority** | High | | **MoSCoW** | Should Have | ## Background and Context Martial Arts is the terminal (capstone) node in the Combat discipline tree. It represents the pinnacle of unarmed combat mastery, requiring a player to have achieved high proficiency in both Kick and Grapple — the two tier-2 branches of the Unarmed specialization. This convergence node requires multiple prerequisites, making it the first multi-prerequisite node in the tree. The Martial Arts node demonstrates the system's ability to handle nodes that depend on multiple prerequisites at specific levels. This pattern will be reused in other discipline trees for their own terminal/convergence nodes. ## Expected Behavior 1. **YAML Definition** added to `conf/skill_trees.yaml`: ```yaml combat_terminal: martial_arts: name: Martial Arts discipline: combat description: "The ultimate synthesis of kicking and grappling arts into a unified martial discipline. Masters of Martial Arts can chain kicks, throws, and locks into devastating combinations." tier: 3 prerequisites: - name: kick level: 5 - name: grapple level: 5 xp_required: 10000 max_level: 10 ``` 2. **Multi-Prerequisite Validation:** - `check_unlockable(player)` must verify BOTH prerequisites are met (Kick >= 5 AND Grapple >= 5). - A player with Kick 5 but Grapple 4 should NOT see Martial Arts as unlockable. - A player with Kick 4 and Grapple 5 should NOT see Martial Arts as unlockable. - Only when both are at level 5+ should Martial Arts appear as unlockable. 3. **Tree Structure:** - `children_of("kick")` should include Martial Arts. - `children_of("grapple")` should include Martial Arts. - `list_by_discipline(:combat)` returns 10 nodes across tiers 0-3. - Martial Arts is the only tier-3 node in the combat discipline. 4. **Full Combat Tree Hierarchy:** ``` Combat (tier 0) ├── Swordplay (tier 1) → Finesse, Power (tier 2) ├── Shield (tier 1) → Guard (tier 2) └── Unarmed (tier 1) → Kick, Grapple (tier 2) → Martial Arts (tier 3) ``` ## Acceptance Criteria - [ ] Martial Arts node is defined in `conf/skill_trees.yaml` at tier 3. - [ ] Martial Arts requires both `kick` at level 5 AND `grapple` at level 5. - [ ] `check_unlockable` only lists Martial Arts when BOTH prerequisites are met. - [ ] `children_of("kick")` includes Martial Arts. - [ ] `children_of("grapple")` includes Martial Arts. - [ ] `list_by_discipline(:combat)` returns 10 nodes across 4 tiers (0-3). - [ ] `validate!` passes with the complete combat tree. - [ ] Multi-prerequisite logic is tested with all combinations (both met, one met, neither met). ## Subtasks - [ ] Add Martial Arts node definition to `conf/skill_trees.yaml` under combat terminal. - [ ] Verify `check_unlockable` handles multi-prerequisite AND logic correctly. - [ ] Test with Kick=5, Grapple=4 (should NOT unlock). - [ ] Test with Kick=4, Grapple=5 (should NOT unlock). - [ ] Test with Kick=5, Grapple=5 (should unlock). - [ ] Verify `children_of("kick")` and `children_of("grapple")` both include Martial Arts. - [ ] Verify full combat tree has 10 nodes across 4 tiers. - [ ] Run `validate!` on the complete combat tree. - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber): Add `tests/unit/martial_arts_terminal.feature` covering multi-prerequisite AND logic, partial prerequisite failure, both prerequisites met, children_of for kick and grapple, full combat tree enumeration, tree validation. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` for Martial Arts terminal node with multi-prerequisite validation. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.