Implement 9-tier reputation system with named thresholds and tier lookup #214

New issue

Open

opened 2026-03-16 01:36:56 +00:00 by freemo · 0 comments

freemo commented

2026-03-16 01:36:56 +00:00

Owner

Metadata

Field	Value
Epic	#201 — Reputation Data Model & Storage
Legendary	#199 — Reputation & Social Standing
Type	Feature
Priority	High
Points	5
MoSCoW	Must Have
Branch	`feature/m4-reputation-tier-system`
Commit Message	`Implement 9-tier reputation system with named thresholds and tier lookup (#214)`

Background and Context

The reputation system uses a 9-tier scale to translate raw numeric scores (-100 to +100) into meaningful, named standings that players can understand and that game systems can reference. Each tier has a defined score range and a human-readable name.

The tiers provide the vocabulary for the entire reputation system — merchants reference tiers for pricing, areas reference tiers for access control, and players see tier names in their reputation displays. Having a clean, centralized tier lookup system ensures consistency across all reputation-dependent features.

The 9 tiers are:

Reviled (-100 to -76)
Hated (-75 to -51)
Hostile (-50 to -26)
Unfriendly (-25 to -6)
Neutral (-5 to +5)
Friendly (+6 to +25)
Respected (+26 to +50)
Honored (+51 to +75)
Exalted (+76 to +100)

Expected Behavior

ReputationTier.tier_for(score) returns the tier symbol (e.g., :reviled, :neutral, :exalted) for a given numeric score.
ReputationTier.tier_name(score) returns the human-readable string (e.g., "Reviled", "Neutral", "Exalted").
ReputationTier.tiers returns all 9 tiers in order from lowest to highest.
ReputationTier.range_for(tier) returns the score range for a given tier symbol.
Scores outside -100..+100 are clamped before tier lookup.
Boundary values map correctly: -76 is Reviled, -75 is Hated, -5 is Neutral, +5 is Neutral, +6 is Friendly, etc.

Acceptance Criteria

ReputationTier module/class exists in lib/aethyr/core/reputation/reputation_tier.rb.
tier_for(score) returns correct tier symbol for all 9 tiers.
tier_name(score) returns correct human-readable name for all 9 tiers.
tiers returns ordered list of all tier symbols.
range_for(tier) returns the correct score range for each tier.
All boundary values between tiers map correctly.
Out-of-range scores are clamped before lookup.

Subtasks

Create lib/aethyr/core/reputation/reputation_tier.rb with the ReputationTier module.
Define the 9-tier constant data structure with names, symbols, and score ranges.
Implement tier_for(score) method.
Implement tier_name(score) method.
Implement tiers method returning ordered tier list.
Implement range_for(tier) method.
Add clamping for out-of-range input scores.
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber): Add tests/unit/reputation_tier.feature covering tier lookup for all 9 tiers, boundary values, out-of-range clamping, tier listing, and range lookup.
Tests (Cucumber Integration): Add integration feature in tests/integration/ for tier system integration with ReputationVector.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.

## Metadata | Field | Value | |-------|-------| | **Epic** | #201 — Reputation Data Model & Storage | | **Legendary** | #199 — Reputation & Social Standing | | **Type** | Feature | | **Priority** | High | | **Points** | 5 | | **MoSCoW** | Must Have | | **Branch** | `feature/m4-reputation-tier-system` | | **Commit Message** | `Implement 9-tier reputation system with named thresholds and tier lookup (#214)` | ## Background and Context The reputation system uses a 9-tier scale to translate raw numeric scores (-100 to +100) into meaningful, named standings that players can understand and that game systems can reference. Each tier has a defined score range and a human-readable name. The tiers provide the vocabulary for the entire reputation system — merchants reference tiers for pricing, areas reference tiers for access control, and players see tier names in their reputation displays. Having a clean, centralized tier lookup system ensures consistency across all reputation-dependent features. The 9 tiers are: - **Reviled** (-100 to -76) - **Hated** (-75 to -51) - **Hostile** (-50 to -26) - **Unfriendly** (-25 to -6) - **Neutral** (-5 to +5) - **Friendly** (+6 to +25) - **Respected** (+26 to +50) - **Honored** (+51 to +75) - **Exalted** (+76 to +100) ## Expected Behavior 1. `ReputationTier.tier_for(score)` returns the tier symbol (e.g., `:reviled`, `:neutral`, `:exalted`) for a given numeric score. 2. `ReputationTier.tier_name(score)` returns the human-readable string (e.g., "Reviled", "Neutral", "Exalted"). 3. `ReputationTier.tiers` returns all 9 tiers in order from lowest to highest. 4. `ReputationTier.range_for(tier)` returns the score range for a given tier symbol. 5. Scores outside -100..+100 are clamped before tier lookup. 6. Boundary values map correctly: -76 is Reviled, -75 is Hated, -5 is Neutral, +5 is Neutral, +6 is Friendly, etc. ## Acceptance Criteria - [ ] `ReputationTier` module/class exists in `lib/aethyr/core/reputation/reputation_tier.rb`. - [ ] `tier_for(score)` returns correct tier symbol for all 9 tiers. - [ ] `tier_name(score)` returns correct human-readable name for all 9 tiers. - [ ] `tiers` returns ordered list of all tier symbols. - [ ] `range_for(tier)` returns the correct score range for each tier. - [ ] All boundary values between tiers map correctly. - [ ] Out-of-range scores are clamped before lookup. ## Subtasks - [ ] Create `lib/aethyr/core/reputation/reputation_tier.rb` with the `ReputationTier` module. - [ ] Define the 9-tier constant data structure with names, symbols, and score ranges. - [ ] Implement `tier_for(score)` method. - [ ] Implement `tier_name(score)` method. - [ ] Implement `tiers` method returning ordered tier list. - [ ] Implement `range_for(tier)` method. - [ ] Add clamping for out-of-range input scores. - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber): Add `tests/unit/reputation_tier.feature` covering tier lookup for all 9 tiers, boundary values, out-of-range clamping, tier listing, and range lookup. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` for tier system integration with ReputationVector. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.