Refactor all inline ES calls to use EventSourceService

freemo commented

2026-03-15 23:08:36 +00:00

Owner

Metadata

Commit Message: refactor(event-sourcing): replace inline Sequent calls with EventSourceService
Branch: feature/m1-refactor-inline-es

Background and Context

After EventSourceService exists, all inline Sequent.command_service.execute_commands calls in Manager, GameObject, and StorageMachine must be refactored to use the service. This eliminates duplicated boilerplate and resolves the double-emission issue where both Manager and StorageMachine emit ES commands for the same operation.

Acceptance Criteria

Zero direct Sequent.command_service.execute_commands calls in Manager, GameObject, or StorageMachine
All ES emission goes through EventSourceService
Double-emission between Manager and StorageMachine eliminated
All existing tests pass with no behavior change

Subtasks

Replace inline ES calls in Manager (add_player, create_object, delete_object, set_password)
Replace inline ES calls in GameObject (long_desc=, container=, update_attributes)
Replace inline ES calls in StorageMachine (save_player, set_password, store_object, delete_object)
Identify and remove duplicate emission points (where Manager AND StorageMachine both emit for same op)
Tests (Cucumber): Verify no behavioral change in existing scenarios
Run bundle exec rake unit, fix any failures
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber Integration): Add integration feature in tests/integration/ verifying all ES command emissions route through EventSourceService.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.

## Metadata - **Commit Message:** `refactor(event-sourcing): replace inline Sequent calls with EventSourceService` - **Branch:** `feature/m1-refactor-inline-es` ## Background and Context After `EventSourceService` exists, all inline `Sequent.command_service.execute_commands` calls in Manager, GameObject, and StorageMachine must be refactored to use the service. This eliminates duplicated boilerplate and resolves the double-emission issue where both Manager and StorageMachine emit ES commands for the same operation. ## Acceptance Criteria - Zero direct `Sequent.command_service.execute_commands` calls in Manager, GameObject, or StorageMachine - All ES emission goes through `EventSourceService` - Double-emission between Manager and StorageMachine eliminated - All existing tests pass with no behavior change ## Subtasks - [ ] Replace inline ES calls in `Manager` (add_player, create_object, delete_object, set_password) - [ ] Replace inline ES calls in `GameObject` (long_desc=, container=, update_attributes) - [ ] Replace inline ES calls in `StorageMachine` (save_player, set_password, store_object, delete_object) - [ ] Identify and remove duplicate emission points (where Manager AND StorageMachine both emit for same op) - [ ] Tests (Cucumber): Verify no behavioral change in existing scenarios - [ ] Run `bundle exec rake unit`, fix any failures - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` verifying all ES command emissions route through EventSourceService. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.