Add integration test for cross-tile world connectivity #55

Open
opened 2026-03-14 23:57:23 +00:00 by freemo · 0 comments
Owner

Metadata

  • Commit Message: test(worldgen): add cross-tile connectivity integration test
  • Branch: feature/m3-cross-tile

Background and Context

No integration tests verify that rooms at tile boundaries connect correctly to rooms in adjacent tiles. Cross-tile connectivity is fundamental to world generation and must be validated to ensure players can move seamlessly between tile regions.

Expected Behavior

An integration test feature file exists that generates rooms from two or more adjacent tile regions and verifies that boundary rooms have properly connected exits pointing to rooms in the neighboring tile, with bidirectional connectivity confirmed.

Acceptance Criteria

  • Integration test generates rooms from at least 2 adjacent tile regions
  • Test verifies that boundary rooms have cross-tile exits
  • Test verifies bidirectional connectivity across tile boundaries
  • All existing tests continue to pass

Subtasks

  • Code: Write integration test feature file in tests/integration/ verifying player movement across tile boundaries
  • Code: Add step definitions for world traversal across tile regions
  • Docs: Update test documentation if applicable
  • Tests (Cucumber): Add tests/unit/cross_tile_connectivity.feature covering tile boundary exit validation, bidirectional connectivity, and missing-exit edge cases.
  • Tests (Cucumber Integration): Add integration feature in tests/integration/ for cross-tile world connectivity.
  • Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions for world generation and tile connectivity.
  • Quality: Verify coverage >=85% via bundle exec rake unit. If coverage is <85% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=85%. Only mark this as complete once coverage is >=85%, if not repeat this task as many times as is needed until coverage reaches >=85%.
  • Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

  • All subtasks above are completed and checked off.
  • A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
  • The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
  • The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.
## Metadata - **Commit Message**: `test(worldgen): add cross-tile connectivity integration test` - **Branch**: `feature/m3-cross-tile` ## Background and Context No integration tests verify that rooms at tile boundaries connect correctly to rooms in adjacent tiles. Cross-tile connectivity is fundamental to world generation and must be validated to ensure players can move seamlessly between tile regions. ## Expected Behavior An integration test feature file exists that generates rooms from two or more adjacent tile regions and verifies that boundary rooms have properly connected exits pointing to rooms in the neighboring tile, with bidirectional connectivity confirmed. ## Acceptance Criteria - [ ] Integration test generates rooms from at least 2 adjacent tile regions - [ ] Test verifies that boundary rooms have cross-tile exits - [ ] Test verifies bidirectional connectivity across tile boundaries - [ ] All existing tests continue to pass ## Subtasks - [ ] Code: Write integration test feature file in `tests/integration/` verifying player movement across tile boundaries - [ ] Code: Add step definitions for world traversal across tile regions - [ ] Docs: Update test documentation if applicable - [ ] Tests (Cucumber): Add `tests/unit/cross_tile_connectivity.feature` covering tile boundary exit validation, bidirectional connectivity, and missing-exit edge cases. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` for cross-tile world connectivity. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions for world generation and tile connectivity. - [ ] Quality: Verify coverage >=85% via `bundle exec rake unit`. If coverage is <85% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=85%. Only mark this as complete once coverage is >=85%, if not repeat this task as many times as is needed until coverage reaches >=85%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.
freemo added this to the v1.1.0 milestone 2026-03-14 23:57:23 +00:00
freemo self-assigned this 2026-03-15 04:25:22 +00:00
freemo modified the milestone from v1.1.0 to v1.2.0 2026-03-16 00:28:09 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference: aethyr/Aethyr#55
No description provided.