aethyr/Aethyr
2
0
Fork 0
Code Issues 281 Pull requests Projects Releases Packages Wiki Activity Actions

Remove dead lib/aethyr/event_sourcing/ directory #37

New issue
Closed
opened 2026-03-14 23:54:56 +00:00 by freemo · 1 comment
freemo commented 2026-03-14 23:54:56 +00:00
Owner
Copy link

Metadata

  • Commit Message: refactor(event-sourcing): remove duplicate event sourcing directory
  • Branch: feature/m1-v12-remove-duplicate-es

Background

lib/aethyr/event_sourcing/ contains configuration.rb and immudb_event_store.rb which are never required by any code. They are a duplicate implementation that was superseded by the consolidation work.

Expected Behavior

The lib/aethyr/event_sourcing/ directory and its contents are removed. Only lib/aethyr/core/event_sourcing/ remains.

Acceptance Criteria

  • lib/aethyr/event_sourcing/configuration.rb deleted
  • lib/aethyr/event_sourcing/immudb_event_store.rb deleted
  • lib/aethyr/event_sourcing/ directory deleted
  • lib/aethyr/event_store_stats.rb updated if it references the removed files
  • No remaining references to Aethyr::EventSourcing::Configuration or Aethyr::EventSourcing::ImmudbEventStore

Subtasks

  • Delete lib/aethyr/event_sourcing/ directory
  • Grep codebase for references to removed classes, update or remove
  • Tests: Run bundle exec rake unit, fix any errors

Definition of Done

This issue is complete when all subtasks are done, commit created on the specified branch, PR submitted and merged.

## Metadata - **Commit Message**: `refactor(event-sourcing): remove duplicate event sourcing directory` - **Branch**: `feature/m1-v12-remove-duplicate-es` ## Background `lib/aethyr/event_sourcing/` contains `configuration.rb` and `immudb_event_store.rb` which are never required by any code. They are a duplicate implementation that was superseded by the consolidation work. ## Expected Behavior The `lib/aethyr/event_sourcing/` directory and its contents are removed. Only `lib/aethyr/core/event_sourcing/` remains. ## Acceptance Criteria - [x] `lib/aethyr/event_sourcing/configuration.rb` deleted - [x] `lib/aethyr/event_sourcing/immudb_event_store.rb` deleted - [x] `lib/aethyr/event_sourcing/` directory deleted - [x] `lib/aethyr/event_store_stats.rb` updated if it references the removed files - [x] No remaining references to `Aethyr::EventSourcing::Configuration` or `Aethyr::EventSourcing::ImmudbEventStore` ## Subtasks - [x] Delete `lib/aethyr/event_sourcing/` directory - [x] Grep codebase for references to removed classes, update or remove - [x] Tests: Run `bundle exec rake unit`, fix any errors ## Definition of Done This issue is complete when all subtasks are done, commit created on the specified branch, PR submitted and merged.
freemo added this to the v1.2.0 milestone 2026-03-14 23:54:56 +00:00
freemo self-assigned this 2026-03-15 04:25:22 +00:00
freemo modified the milestone from v1.2.0 to v1.0.0 2026-03-15 23:19:34 +00:00
freemo commented 2026-03-31 05:43:16 +00:00
Author
Owner
Copy link

Implementation Notes

Changes Made

  1. Deleted lib/aethyr/event_sourcing/ directory — removed configuration.rb (168 lines) and immudb_event_store.rb (414 lines), the duplicate implementations superseded by lib/aethyr/core/event_sourcing/.

  2. Deleted tests/unit/event_sourcing_configuration.feature (128 lines) — this feature file exclusively tested Aethyr::EventSourcing::Configuration, the removed duplicate class.

  3. Deleted tests/unit/step_definitions/event_sourcing_configuration_steps.rb (255 lines) — step definitions for the above feature.

  4. Updated tests/unit/immudb_event_store.feature — removed the first 194 lines of scenarios that tested Aethyr::EventSourcing::ImmudbEventStore (the duplicate). Retained all 52 core scenarios testing Aethyr::Core::EventSourcing::ImmudbEventStore.

  5. Updated tests/unit/step_definitions/immudb_event_store_steps.rb — removed ~736 lines of duplicate-class-specific code (Prometheus stubs, Sequent stubs, mock builders, and step definitions). Retained all core event store step definitions and infrastructure.

Verification

  • lib/aethyr/event_store_stats.rb was inspected and does not reference the removed files/classes (only references event_sourcing_enabled config key).
  • Full codebase grep for Aethyr::EventSourcing::Configuration, Aethyr::EventSourcing::ImmudbEventStore, aethyr/event_sourcing/configuration, and aethyr/event_sourcing/immudb_event_store returns zero results.
  • The core event sourcing directory lib/aethyr/core/event_sourcing/ is untouched.

Test Results

  • immudb_event_store.feature: 52 scenarios, 198 steps — all passed
  • rubocop: No new offenses introduced (pre-existing Ruby 2.4 parser warnings unchanged)
  • Net deletion: 1,885 lines removed, 6 lines added

Summary

  • 6 files changed, 6 insertions(+), 1,885 deletions(-)
  • 2 source files deleted, 2 test files deleted, 2 test files updated
## Implementation Notes ### Changes Made 1. **Deleted `lib/aethyr/event_sourcing/` directory** — removed `configuration.rb` (168 lines) and `immudb_event_store.rb` (414 lines), the duplicate implementations superseded by `lib/aethyr/core/event_sourcing/`. 2. **Deleted `tests/unit/event_sourcing_configuration.feature`** (128 lines) — this feature file exclusively tested `Aethyr::EventSourcing::Configuration`, the removed duplicate class. 3. **Deleted `tests/unit/step_definitions/event_sourcing_configuration_steps.rb`** (255 lines) — step definitions for the above feature. 4. **Updated `tests/unit/immudb_event_store.feature`** — removed the first 194 lines of scenarios that tested `Aethyr::EventSourcing::ImmudbEventStore` (the duplicate). Retained all 52 core scenarios testing `Aethyr::Core::EventSourcing::ImmudbEventStore`. 5. **Updated `tests/unit/step_definitions/immudb_event_store_steps.rb`** — removed ~736 lines of duplicate-class-specific code (Prometheus stubs, Sequent stubs, mock builders, and step definitions). Retained all core event store step definitions and infrastructure. ### Verification - `lib/aethyr/event_store_stats.rb` was inspected and does **not** reference the removed files/classes (only references `event_sourcing_enabled` config key). - Full codebase grep for `Aethyr::EventSourcing::Configuration`, `Aethyr::EventSourcing::ImmudbEventStore`, `aethyr/event_sourcing/configuration`, and `aethyr/event_sourcing/immudb_event_store` returns **zero results**. - The core event sourcing directory `lib/aethyr/core/event_sourcing/` is untouched. ### Test Results - **immudb_event_store.feature**: 52 scenarios, 198 steps — **all passed** - **rubocop**: No new offenses introduced (pre-existing Ruby 2.4 parser warnings unchanged) - Net deletion: **1,885 lines removed**, 6 lines added ### Summary - 6 files changed, 6 insertions(+), 1,885 deletions(-) - 2 source files deleted, 2 test files deleted, 2 test files updated
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
feature/m2-headless-renderer
dependabot/bundler/rdoc-6.3.2
dependabot/bundler/rexml-3.2.5
dependabot/bundler/json-tw-2.3
inprogress
dependabot/bundler/rake-tw-13.0
No results found.
Labels
Clear labels   
Blocked

Cannot proceed, depends on unresolved issue

  
Duplicate

Issue is a duplicate of an existing one

  
MoSCoW/Could Have

Desirable but not necessary, included if time permits

  
MoSCoW/Must Have

Essential, project cannot ship without it

  
MoSCoW/Should Have

Important but not strictly essential

  
Points/1

Estimated effort: 1 story points

  
Points/13

Estimated effort: 13 story points

  
Points/2

Estimated effort: 2 story points

  
Points/21

Estimated effort: 21 story points

  
Points/3

Estimated effort: 3 story points

  
Points/5

Estimated effort: 5 story points

  
Points/8

Estimated effort: 8 story points

  
Priority/Backlog

Not yet prioritized

  
Priority/Critical

Must be addressed immediately

  
Priority/High

Important, should be completed soon

  
Priority/Low

Nice to have, not time-sensitive

  
Priority/Medium

Normal priority, valid and should be addressed

  
State/Completed

Issue resolved and all PRs merged

  
State/In progress

Someone is actively working on this issue

  
State/In review

Implementation complete, PR submitted for review

  
State/Paused

Work temporarily suspended, typically blocked

  
State/Unverified

Issue created but not yet reviewed by a maintainer

  
State/Verified

Maintainer confirmed valid and actionable

  
State/Wont Do

Deliberate decision not to address this issue

  
Type/Bug

A defect in existing functionality

  
Type/Epic

Large body of work broken into multiple issues

  
Type/Feature

A new capability or user story

  
Type/Legendary

Major strategic pillar composed of multiple Epics

  
Type/Task

Technical or administrative work (not bug or feature)

  
Type/Testing

Test-only work item (TDD, test infrastructure, coverage)

No labels
Blocked
Duplicate
MoSCoW/Could Have
MoSCoW/Must Have
MoSCoW/Should Have
Points/1
Points/13
Points/2
Points/21
Points/3
Points/5
Points/8
Priority/Backlog
Priority/Critical
Priority/High
Priority/Low
Priority/Medium
State/Completed
State/In progress
State/In review
State/Paused
State/Unverified
State/Verified
State/Wont Do
Type/Bug
Type/Epic
Type/Feature
Type/Legendary
Type/Task
Type/Testing
Milestone
Clear milestone
No items
No milestone
v1.0.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
freemo
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
#18 Epic: Consolidate dual ImmuDB event store implementations
aethyr/Aethyr
Reference: aethyr/Aethyr#37
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?