aethyr/Aethyr
2
0
Fork 0
Code Issues 281 Pull requests Projects Releases Packages Wiki Activity Actions

refactor(event-sourcing): remove duplicate event sourcing directory #339

Merged
freemo merged 1 commit from feature/m1-v12-remove-duplicate-es into master 2026-04-01 01:52:40 +00:00
Conversation 0 Commits 1 Files changed 6 +6 -1885
freemo commented 2026-03-31 05:43:25 +00:00
Owner
Copy link

Summary

  • Deleted the dead lib/aethyr/event_sourcing/ directory containing configuration.rb and immudb_event_store.rb, which were superseded by the consolidated implementation in lib/aethyr/core/event_sourcing/
  • Removed associated test files (event_sourcing_configuration.feature, event_sourcing_configuration_steps.rb) and cleaned up immudb_event_store.feature and its step definitions to only test the core implementation
  • Verified no remaining references to Aethyr::EventSourcing::Configuration or Aethyr::EventSourcing::ImmudbEventStore anywhere in the codebase

Test Results

  • 52 core event store scenarios, 198 steps — all passed
  • Net: 6 files changed, 1,885 lines removed

Closes #37

## Summary - Deleted the dead `lib/aethyr/event_sourcing/` directory containing `configuration.rb` and `immudb_event_store.rb`, which were superseded by the consolidated implementation in `lib/aethyr/core/event_sourcing/` - Removed associated test files (`event_sourcing_configuration.feature`, `event_sourcing_configuration_steps.rb`) and cleaned up `immudb_event_store.feature` and its step definitions to only test the core implementation - Verified no remaining references to `Aethyr::EventSourcing::Configuration` or `Aethyr::EventSourcing::ImmudbEventStore` anywhere in the codebase ## Test Results - 52 core event store scenarios, 198 steps — all passed - Net: 6 files changed, 1,885 lines removed Closes #37
freemo added this to the v1.0.0 milestone 2026-03-31 05:43:25 +00:00
refactor(event-sourcing): remove duplicate event sourcing directory
Some checks failed
CI / type_check (pull_request) Failing after 47s
Details
CI / lint (pull_request) Failing after 47s
Details
CI / unit_tests (pull_request) Failing after 21m2s
Details
CI / build (pull_request) Has been skipped
Details
CI / integration_tests (pull_request) Failing after 4m4s
Details
71e32f8910 
Removed the dead lib/aethyr/event_sourcing/ directory containing configuration.rb
and immudb_event_store.rb, which were superseded by the consolidated implementation
in lib/aethyr/core/event_sourcing/. Removed associated test files and updated the
remaining immudb_event_store.feature and step definitions to only test the core
implementation. No remaining references to Aethyr::EventSourcing::Configuration
or Aethyr::EventSourcing::ImmudbEventStore.

ISSUES CLOSED: #37
freemo force-pushed feature/m1-v12-remove-duplicate-es from 71e32f8910 to 2f5bd7ed72 2026-03-31 18:45:53 +00:00 Compare
freemo force-pushed feature/m1-v12-remove-duplicate-es from 2f5bd7ed72 to a58f20ceec 2026-03-31 19:22:06 +00:00 Compare
freemo force-pushed feature/m1-v12-remove-duplicate-es from a58f20ceec to 3da8ca38f6 2026-03-31 21:13:39 +00:00 Compare
freemo force-pushed feature/m1-v12-remove-duplicate-es from 3da8ca38f6 to 21f24399aa 2026-04-01 00:54:13 +00:00 Compare
freemo force-pushed feature/m1-v12-remove-duplicate-es from 21f24399aa to e38a05af45 2026-04-01 01:18:03 +00:00 Compare
freemo merged commit 5af7d34a0a into master 2026-04-01 01:52:40 +00:00
freemo deleted branch feature/m1-v12-remove-duplicate-es 2026-04-01 01:52:40 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Blocked

Cannot proceed, depends on unresolved issue

  
Duplicate

Issue is a duplicate of an existing one

  
MoSCoW/Could Have

Desirable but not necessary, included if time permits

  
MoSCoW/Must Have

Essential, project cannot ship without it

  
MoSCoW/Should Have

Important but not strictly essential

  
Points/1

Estimated effort: 1 story points

  
Points/13

Estimated effort: 13 story points

  
Points/2

Estimated effort: 2 story points

  
Points/21

Estimated effort: 21 story points

  
Points/3

Estimated effort: 3 story points

  
Points/5

Estimated effort: 5 story points

  
Points/8

Estimated effort: 8 story points

  
Priority/Backlog

Not yet prioritized

  
Priority/Critical

Must be addressed immediately

  
Priority/High

Important, should be completed soon

  
Priority/Low

Nice to have, not time-sensitive

  
Priority/Medium

Normal priority, valid and should be addressed

  
State/Completed

Issue resolved and all PRs merged

  
State/In progress

Someone is actively working on this issue

  
State/In review

Implementation complete, PR submitted for review

  
State/Paused

Work temporarily suspended, typically blocked

  
State/Unverified

Issue created but not yet reviewed by a maintainer

  
State/Verified

Maintainer confirmed valid and actionable

  
State/Wont Do

Deliberate decision not to address this issue

  
Type/Bug

A defect in existing functionality

  
Type/Epic

Large body of work broken into multiple issues

  
Type/Feature

A new capability or user story

  
Type/Legendary

Major strategic pillar composed of multiple Epics

  
Type/Task

Technical or administrative work (not bug or feature)

  
Type/Testing

Test-only work item (TDD, test infrastructure, coverage)

No labels
Blocked
Duplicate
MoSCoW/Could Have
MoSCoW/Must Have
MoSCoW/Should Have
Points/1
Points/13
Points/2
Points/21
Points/3
Points/5
Points/8
Priority/Backlog
Priority/Critical
Priority/High
Priority/Low
Priority/Medium
State/Completed
State/In progress
State/In review
State/Paused
State/Unverified
State/Verified
State/Wont Do
Type/Bug
Type/Epic
Type/Feature
Type/Legendary
Type/Task
Type/Testing
Milestone
Clear milestone
No items
No milestone
v1.0.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: aethyr/Aethyr#339
No description provided.
Delete branch "feature/m1-v12-remove-duplicate-es"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?