Implement multi-player combat with shared opponent action point budget

## Metadata - **Commit Message**: `feat(combat): implement multi-player combat with shared AP budget` - **Branch**: `feature/m4-multiplayer-combat` ## Background and Context Combat can involve multiple players vs one or more opponents. When multiple players attack the same target, the target's AP budget is shared across defending against all attackers. This creates tactical advantage for coordinated groups. ## Expected Behavior CombatInstance supports 2+ combatants. Each combatant has independent AP. During Resolution, all actions from all combatants are resolved together. Targeting allows specifying which opponent to attack. ## Acceptance Criteria - [ ] CombatInstance supports arbitrary number of combatants - [ ] Each combatant selects actions independently - [ ] All actions resolve in a single Resolution phase - [ ] Players can target specific opponents ## Subtasks - [ ] Code: Extend CombatInstance to track multiple combatants - [ ] Code: Add target selection to action submission - [ ] Code: Modify Resolution to handle multi-combatant action sets - [ ] Code: Update combat display for multiple combatants - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber): Add `tests/unit/multiplayer_combat.feature` covering 3-way combat, target selection, multi-combatant resolution. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` for multi-player combat instance. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.

freemo commented

2026-03-16 01:50:21 +00:00

Owner

Metadata

Commit Message: feat(combat): implement multi-player combat with shared AP budget
Branch: feature/m4-multiplayer-combat

Background and Context

Combat can involve multiple players vs one or more opponents. When multiple players attack the same target, the target's AP budget is shared across defending against all attackers. This creates tactical advantage for coordinated groups.

Expected Behavior

CombatInstance supports 2+ combatants. Each combatant has independent AP. During Resolution, all actions from all combatants are resolved together. Targeting allows specifying which opponent to attack.

Acceptance Criteria

CombatInstance supports arbitrary number of combatants
Each combatant selects actions independently
All actions resolve in a single Resolution phase
Players can target specific opponents

Subtasks

Code: Extend CombatInstance to track multiple combatants
Code: Add target selection to action submission
Code: Modify Resolution to handle multi-combatant action sets
Code: Update combat display for multiple combatants
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber): Add tests/unit/multiplayer_combat.feature covering 3-way combat, target selection, multi-combatant resolution.
Tests (Cucumber Integration): Add integration feature in tests/integration/ for multi-player combat instance.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.