Implement weapon skill level thresholds (1-5-10-15-20) that unlock progressively powerful moves

## Metadata - **Commit Message**: `feat(combat): implement skill level thresholds for move unlocks` - **Branch**: `feature/m4-move-unlocks` ## Background and Context Combat actions have skill_requirements. As weapon skill levels increase (thresholds: 1, 5, 10, 15, 20), more powerful moves become available. Basic moves require level 1; advanced moves require level 10-20. ## Expected Behavior CombatActionCatalog filters available actions based on the combatant's skill levels. Only actions whose skill_requirements are met appear in the player's action menu. ## Acceptance Criteria - [ ] Actions with unmet skill requirements are hidden from action menu - [ ] Level 1 threshold grants basic attacks - [ ] Level 5/10/15/20 thresholds progressively unlock advanced moves - [ ] Newly unlocked moves are announced to the player ## Subtasks - [ ] Code: Add skill_requirements to all CombatAction definitions - [ ] Code: Filter CombatActionCatalog.available_for(combatant) by skill levels - [ ] Code: Announce newly available moves on level-up - [ ] Code: Add skill level display to action detail overlay - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber): Add `tests/unit/move_unlocks.feature` covering filtered action list by level, progressive unlock, announcement. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` for move unlocks as player gains combat XP. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.

freemo commented

2026-03-16 01:50:20 +00:00

Owner

Metadata

Commit Message: feat(combat): implement skill level thresholds for move unlocks
Branch: feature/m4-move-unlocks

Background and Context

Combat actions have skill_requirements. As weapon skill levels increase (thresholds: 1, 5, 10, 15, 20), more powerful moves become available. Basic moves require level 1; advanced moves require level 10-20.

Expected Behavior

CombatActionCatalog filters available actions based on the combatant's skill levels. Only actions whose skill_requirements are met appear in the player's action menu.

Acceptance Criteria

Actions with unmet skill requirements are hidden from action menu
Level 1 threshold grants basic attacks
Level 5/10/15/20 thresholds progressively unlock advanced moves
Newly unlocked moves are announced to the player

Subtasks

Code: Add skill_requirements to all CombatAction definitions
Code: Filter CombatActionCatalog.available_for(combatant) by skill levels
Code: Announce newly available moves on level-up
Code: Add skill level display to action detail overlay
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber): Add tests/unit/move_unlocks.feature covering filtered action list by level, progressive unlock, announcement.
Tests (Cucumber Integration): Add integration feature in tests/integration/ for move unlocks as player gains combat XP.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.