Implement per-weapon-type combat XP tracking and skill progression

## Metadata - **Commit Message**: `feat(combat): implement per-weapon-type combat XP tracking` - **Branch**: `feature/m4-combat-xp` ## Background and Context Using a weapon type in combat grants XP in that weapon's skill. 8 weapon skills map to the Combat discipline tree: Swordplay, Shield, Unarmed, and their sub-branches. ## Expected Behavior After each combat round, XP is awarded based on actions used. XP accumulates per weapon type. Level thresholds follow the 10,000 XP/level standard. ## Acceptance Criteria - [ ] Combat actions grant XP to the appropriate weapon skill - [ ] XP scales with action complexity (higher AP actions grant more XP) - [ ] Skill levels increase at 10,000 XP thresholds - [ ] Level-up publishes :skill_level_up Wisper event ## Subtasks - [ ] Code: Add combat XP calculation to CombatResolver post-resolution - [ ] Code: Map weapon types to skill tree nodes - [ ] Code: Award XP proportional to AP cost of actions used - [ ] Code: Integrate with skill tree XP tracking from Character Progression system - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber): Add `tests/unit/combat_xp.feature` covering XP gain per action, weapon type mapping, level threshold. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` for XP gain after combat rounds. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.

freemo commented

2026-03-16 01:50:19 +00:00

Owner

Metadata

Commit Message: feat(combat): implement per-weapon-type combat XP tracking
Branch: feature/m4-combat-xp

Background and Context

Using a weapon type in combat grants XP in that weapon's skill. 8 weapon skills map to the Combat discipline tree: Swordplay, Shield, Unarmed, and their sub-branches.

Expected Behavior

After each combat round, XP is awarded based on actions used. XP accumulates per weapon type. Level thresholds follow the 10,000 XP/level standard.

Acceptance Criteria

Combat actions grant XP to the appropriate weapon skill
XP scales with action complexity (higher AP actions grant more XP)
Skill levels increase at 10,000 XP thresholds
Level-up publishes :skill_level_up Wisper event

Subtasks

Code: Add combat XP calculation to CombatResolver post-resolution
Code: Map weapon types to skill tree nodes
Code: Award XP proportional to AP cost of actions used
Code: Integrate with skill tree XP tracking from Character Progression system
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber): Add tests/unit/combat_xp.feature covering XP gain per action, weapon type mapping, level threshold.
Tests (Cucumber Integration): Add integration feature in tests/integration/ for XP gain after combat rounds.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.