Implement compact combat view for narrow terminals (<=120 cols) #283

Open
opened 2026-03-16 01:50:18 +00:00 by freemo · 0 comments
Owner

Metadata

  • Commit Message: feat(combat): implement compact combat view for narrow terminals
  • Branch: feature/m4-compact-combat

Background and Context

When the terminal width is <=120 columns, the full side-by-side combat display doesn't fit. A compact view shows one grid at a time (toggleable), condensed health bars, and abbreviated combat log.

Expected Behavior

The combat display adapts based on terminal width (via NAWS). Below 120 cols, it switches to compact mode with single-grid view, abbreviated labels, and stacked layout.

Acceptance Criteria

  • Automatic switch to compact mode below 120 cols
  • Single grid view with toggle between player/opponent
  • Condensed health indicators (single character per body part)
  • Abbreviated combat log

Subtasks

  • Code: Add terminal width detection to combat display
  • Code: Implement compact grid rendering (3-column width)
  • Code: Implement grid toggle command during combat
  • Code: Implement condensed health and status indicators
  • Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
  • Tests (Cucumber): Add tests/unit/compact_combat.feature covering compact mode activation, grid toggle, condensed display.
  • Tests (Cucumber Integration): Add integration feature in tests/integration/ for compact combat view on narrow terminal.
  • Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
  • Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
  • Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

  • All subtasks above are completed and checked off.
  • A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
  • The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
  • The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.
## Metadata - **Commit Message**: `feat(combat): implement compact combat view for narrow terminals` - **Branch**: `feature/m4-compact-combat` ## Background and Context When the terminal width is <=120 columns, the full side-by-side combat display doesn't fit. A compact view shows one grid at a time (toggleable), condensed health bars, and abbreviated combat log. ## Expected Behavior The combat display adapts based on terminal width (via NAWS). Below 120 cols, it switches to compact mode with single-grid view, abbreviated labels, and stacked layout. ## Acceptance Criteria - [ ] Automatic switch to compact mode below 120 cols - [ ] Single grid view with toggle between player/opponent - [ ] Condensed health indicators (single character per body part) - [ ] Abbreviated combat log ## Subtasks - [ ] Code: Add terminal width detection to combat display - [ ] Code: Implement compact grid rendering (3-column width) - [ ] Code: Implement grid toggle command during combat - [ ] Code: Implement condensed health and status indicators - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber): Add `tests/unit/compact_combat.feature` covering compact mode activation, grid toggle, condensed display. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` for compact combat view on narrow terminal. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.
freemo added this to the v1.3.0 milestone 2026-03-16 01:50:18 +00:00
freemo self-assigned this 2026-03-16 01:50:18 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
Reference: aethyr/Aethyr#283
No description provided.