Implement action detail screen overlay with Statistics, Pattern, Impact, Notes

## Metadata - **Commit Message**: `feat(combat): implement action detail screen overlay` - **Branch**: `feature/m4-action-detail` ## Background and Context Players can inspect any combat action to see its details in a 4-section overlay: Statistics (AP cost, delay, damage, momentum type), Relative Movement Pattern (visual grid showing strike cells), Projected Impact (which body parts would be hit from current position), Tactical Notes (tips on when to use the action). ## Expected Behavior Typing `detail <action_name>` during combat Planning phase shows the overlay. The overlay is dismissible with ESC or Enter. ## Acceptance Criteria - [ ] `detail <action>` command shows overlay during Planning phase - [ ] Statistics section shows all numeric properties - [ ] Pattern section shows ASCII grid with strike cells highlighted - [ ] Impact section shows body parts that would be hit from current hand position - [ ] Overlay dismissible with ESC or Enter ## Subtasks - [ ] Code: Create `lib/aethyr/core/combat/action_detail_display.rb` - [ ] Code: Implement Statistics section with formatted action properties - [ ] Code: Implement Pattern section with ASCII grid visualization - [ ] Code: Implement Impact section projecting pattern from current hand position - [ ] Code: Implement Tactical Notes section from action description - [ ] Code: Add `detail` command handler for combat mode - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber): Add `tests/unit/action_detail.feature` covering overlay rendering, statistics accuracy, pattern visualization, impact projection. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` for action detail overlay during combat planning. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.

freemo commented

2026-03-16 01:50:18 +00:00

Owner

Metadata

Commit Message: feat(combat): implement action detail screen overlay
Branch: feature/m4-action-detail

Background and Context

Players can inspect any combat action to see its details in a 4-section overlay: Statistics (AP cost, delay, damage, momentum type), Relative Movement Pattern (visual grid showing strike cells), Projected Impact (which body parts would be hit from current position), Tactical Notes (tips on when to use the action).

Expected Behavior

Typing detail <action_name> during combat Planning phase shows the overlay. The overlay is dismissible with ESC or Enter.

Acceptance Criteria

detail <action> command shows overlay during Planning phase
Statistics section shows all numeric properties
Pattern section shows ASCII grid with strike cells highlighted
Impact section shows body parts that would be hit from current hand position
Overlay dismissible with ESC or Enter

Subtasks

Code: Create lib/aethyr/core/combat/action_detail_display.rb
Code: Implement Statistics section with formatted action properties
Code: Implement Pattern section with ASCII grid visualization
Code: Implement Impact section projecting pattern from current hand position
Code: Implement Tactical Notes section from action description
Code: Add detail command handler for combat mode
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber): Add tests/unit/action_detail.feature covering overlay rendering, statistics accuracy, pattern visualization, impact projection.
Tests (Cucumber Integration): Add integration feature in tests/integration/ for action detail overlay during combat planning.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.