Implement combat screen display with body grid visualization and health bars

## Metadata - **Commit Message**: `feat(combat): implement combat screen with body grid visualization` - **Branch**: `feature/m4-combat-screen` ## Background and Context The combat screen shows the body grid for each combatant with body part health bars, hand positions, pending delayed actions (telegraph), AP remaining, and combat log. The screen renders in the main content window during combat. ## Expected Behavior A formatted combat display shows: two body grids side by side (player and opponent), health bars per body part using color coding, hand positions marked on grid, telegraph section for pending actions, AP indicator, and scrollable combat log. ## Acceptance Criteria - [ ] Body grid displays with body parts colored by health percentage - [ ] Hand positions shown on grid with weapon icons - [ ] Telegraph section shows pending delayed actions - [ ] AP remaining displayed clearly - [ ] Combat log shows recent action results ## Subtasks - [ ] Code: Create `lib/aethyr/core/combat/combat_display.rb` with formatting methods - [ ] Code: Implement body grid ASCII art with color-coded health indicators - [ ] Code: Implement hand position markers on the grid - [ ] Code: Implement telegraph section rendering - [ ] Code: Implement AP and status bar rendering - [ ] Code: Integrate with combat events to update display on each phase - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber): Add `tests/unit/combat_screen.feature` covering grid rendering, health colors, hand positions, telegraph section. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` for combat screen display during live combat. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.

freemo commented

2026-03-16 01:50:18 +00:00

Owner

Metadata

Commit Message: feat(combat): implement combat screen with body grid visualization
Branch: feature/m4-combat-screen

Background and Context

The combat screen shows the body grid for each combatant with body part health bars, hand positions, pending delayed actions (telegraph), AP remaining, and combat log. The screen renders in the main content window during combat.

Expected Behavior

A formatted combat display shows: two body grids side by side (player and opponent), health bars per body part using color coding, hand positions marked on grid, telegraph section for pending actions, AP indicator, and scrollable combat log.

Acceptance Criteria

Body grid displays with body parts colored by health percentage
Hand positions shown on grid with weapon icons
Telegraph section shows pending delayed actions
AP remaining displayed clearly
Combat log shows recent action results

Subtasks

Code: Create lib/aethyr/core/combat/combat_display.rb with formatting methods
Code: Implement body grid ASCII art with color-coded health indicators
Code: Implement hand position markers on the grid
Code: Implement telegraph section rendering
Code: Implement AP and status bar rendering
Code: Integrate with combat events to update display on each phase
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber): Add tests/unit/combat_screen.feature covering grid rendering, health colors, hand positions, telegraph section.
Tests (Cucumber Integration): Add integration feature in tests/integration/ for combat screen display during live combat.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.