Implement stance changes: Shift Aggressive/Defensive/Balanced, Retreat Step

freemo commented

2026-03-16 01:50:17 +00:00

Owner

Metadata

Commit Message: feat(combat): implement 4 stance change actions
Branch: feature/m4-stance-changes

Background and Context

Define 4 stance changes: Shift Aggressive (bonus damage, less defense), Shift Defensive (bonus defense, less damage), Shift Balanced (neutral), Retreat Step (move backward, disengage). Stances modify AP costs and damage multipliers.

Expected Behavior

Stance changes cost 1 AP and modify the combatant's stance state. The stance affects hand starting positions and damage/defense multipliers.

Acceptance Criteria

4 stance changes defined with 1 AP cost each
Aggressive: +20% damage, -20% block coverage
Defensive: -20% damage, +20% block coverage
Balanced: no modifiers (default)
Retreat Step: disengage from combat (costs 2 AP)

Subtasks

Code: Create lib/aethyr/core/combat/actions/stances.rb defining 4 stances
Code: Implement stance modifier system on CombatantState
Code: Integrate stance modifiers into damage calculation and block resolution
Code: Register in CombatActionCatalog
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber): Add tests/unit/stance_changes.feature covering stance switching, modifier application, retreat disengage.
Tests (Cucumber Integration): Add integration feature in tests/integration/ for stance changes affecting combat.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.

## Metadata - **Commit Message**: `feat(combat): implement 4 stance change actions` - **Branch**: `feature/m4-stance-changes` ## Background and Context Define 4 stance changes: Shift Aggressive (bonus damage, less defense), Shift Defensive (bonus defense, less damage), Shift Balanced (neutral), Retreat Step (move backward, disengage). Stances modify AP costs and damage multipliers. ## Expected Behavior Stance changes cost 1 AP and modify the combatant's stance state. The stance affects hand starting positions and damage/defense multipliers. ## Acceptance Criteria - [ ] 4 stance changes defined with 1 AP cost each - [ ] Aggressive: +20% damage, -20% block coverage - [ ] Defensive: -20% damage, +20% block coverage - [ ] Balanced: no modifiers (default) - [ ] Retreat Step: disengage from combat (costs 2 AP) ## Subtasks - [ ] Code: Create `lib/aethyr/core/combat/actions/stances.rb` defining 4 stances - [ ] Code: Implement stance modifier system on CombatantState - [ ] Code: Integrate stance modifiers into damage calculation and block resolution - [ ] Code: Register in CombatActionCatalog - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber): Add `tests/unit/stance_changes.feature` covering stance switching, modifier application, retreat disengage. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` for stance changes affecting combat. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.