Implement empty-hand and unarmed moves: Grab, Push, Punch, Jab, Hook, Uppercut, Kick, Flurry

## Metadata - **Commit Message**: `feat(combat): implement 8 empty-hand and unarmed combat moves` - **Branch**: `feature/m4-unarmed-moves` ## Background and Context Define 3 empty-hand moves (Grab, Push, Punch) and 5 unarmed moves (Jab, Hook, Uppercut, Roundhouse Kick, Flurry). Empty-hand moves are available to any configuration with a free hand. Unarmed moves require the :unarmed configuration. ## Expected Behavior Unarmed moves use body parts directly (fists, feet) with lower damage but faster execution and lower AP costs. ## Acceptance Criteria - [ ] 3 empty-hand moves available with any free hand - [ ] 5 unarmed moves require :unarmed configuration - [ ] Lower AP costs and delays than weapon attacks - [ ] Grab and Push have utility effects (hold, displacement) ## Subtasks - [ ] Code: Create `lib/aethyr/core/combat/actions/unarmed.rb` defining all 8 moves - [ ] Code: Implement Grab with hold mechanic (target loses 1 AP next turn) - [ ] Code: Implement Push with displacement (target moves on grid) - [ ] Code: Register in CombatActionCatalog - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber): Add `tests/unit/unarmed_moves.feature` covering empty-hand availability, unarmed requirement, grab/push effects. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` for unarmed combat actions. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.

freemo commented

2026-03-16 01:50:16 +00:00

Owner

Metadata

Commit Message: feat(combat): implement 8 empty-hand and unarmed combat moves
Branch: feature/m4-unarmed-moves

Background and Context

Define 3 empty-hand moves (Grab, Push, Punch) and 5 unarmed moves (Jab, Hook, Uppercut, Roundhouse Kick, Flurry). Empty-hand moves are available to any configuration with a free hand. Unarmed moves require the :unarmed configuration.

Expected Behavior

Unarmed moves use body parts directly (fists, feet) with lower damage but faster execution and lower AP costs.

Acceptance Criteria

3 empty-hand moves available with any free hand
5 unarmed moves require :unarmed configuration
Lower AP costs and delays than weapon attacks
Grab and Push have utility effects (hold, displacement)

Subtasks

Code: Create lib/aethyr/core/combat/actions/unarmed.rb defining all 8 moves
Code: Implement Grab with hold mechanic (target loses 1 AP next turn)
Code: Implement Push with displacement (target moves on grid)
Code: Register in CombatActionCatalog
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber): Add tests/unit/unarmed_moves.feature covering empty-hand availability, unarmed requirement, grab/push effects.
Tests (Cucumber Integration): Add integration feature in tests/integration/ for unarmed combat actions.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.