Implement shield moves: Block High/Low/Right/Left, Full Guard, Shield Bash, Shield Sweep, Bulwark

freemo commented

2026-03-16 01:50:16 +00:00

Owner

Metadata

Commit Message: feat(combat): implement 9 shield defensive and offensive moves
Branch: feature/m4-shield-moves

Background and Context

Define 9 shield moves: Block High, Block Low, Block Right, Block Left, Full Guard, Shield Bash, Shield Sweep Right, Shield Sweep Up, Bulwark. Block moves cover specific grid regions. Shield Bash is offensive. Full Guard and Bulwark cover large areas at higher AP cost.

Expected Behavior

Shield moves define path patterns on the body grid. Defensive moves generate blocked cell sets during resolution. Shield Bash deals damage.

Acceptance Criteria

All 9 shield moves defined with correct properties
Directional blocks cover appropriate grid regions
Full Guard covers the entire front body at 3 AP
Shield Bash deals damage with knockback
Bulwark provides maximum coverage at high AP cost

Subtasks

Code: Create lib/aethyr/core/combat/actions/shield.rb defining all 9 shield moves
Code: Define block patterns for each directional block
Code: Implement Shield Bash as an offensive action with damage
Code: Register in CombatActionCatalog
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber): Add tests/unit/shield_moves.feature covering block coverage patterns, shield bash damage, full guard coverage.
Tests (Cucumber Integration): Add integration feature in tests/integration/ for shield moves blocking attacks in combat.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.

## Metadata - **Commit Message**: `feat(combat): implement 9 shield defensive and offensive moves` - **Branch**: `feature/m4-shield-moves` ## Background and Context Define 9 shield moves: Block High, Block Low, Block Right, Block Left, Full Guard, Shield Bash, Shield Sweep Right, Shield Sweep Up, Bulwark. Block moves cover specific grid regions. Shield Bash is offensive. Full Guard and Bulwark cover large areas at higher AP cost. ## Expected Behavior Shield moves define path patterns on the body grid. Defensive moves generate blocked cell sets during resolution. Shield Bash deals damage. ## Acceptance Criteria - [ ] All 9 shield moves defined with correct properties - [ ] Directional blocks cover appropriate grid regions - [ ] Full Guard covers the entire front body at 3 AP - [ ] Shield Bash deals damage with knockback - [ ] Bulwark provides maximum coverage at high AP cost ## Subtasks - [ ] Code: Create `lib/aethyr/core/combat/actions/shield.rb` defining all 9 shield moves - [ ] Code: Define block patterns for each directional block - [ ] Code: Implement Shield Bash as an offensive action with damage - [ ] Code: Register in CombatActionCatalog - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber): Add `tests/unit/shield_moves.feature` covering block coverage patterns, shield bash damage, full guard coverage. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` for shield moves blocking attacks in combat. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.