Implement dual-wield attacks: Dual Cross, Alternating Flurry, Scissor Cut

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks

#273 Epic: Combat Action Catalog

aethyr/Aethyr

Reference: aethyr/Aethyr#276

freemo commented

2026-03-16 01:50:15 +00:00

Owner

Metadata

Commit Message: feat(combat): implement 3 dual-wield attack actions
Branch: feature/m4-dualwield-attacks

Background and Context

Define 3 dual-wield attacks: Dual Cross, Alternating Flurry, Scissor Cut. These require the :dual_wield configuration and use both hands.

Expected Behavior

All 3 dual-wield attacks defined as CombatActions with multi-strike patterns using both hands.

Acceptance Criteria

All 3 dual-wield attacks defined with correct properties
Equipment requirement: dual_wield configuration
Multi-strike patterns using alternating hands

Subtasks

Code: Create lib/aethyr/core/combat/actions/dual_wield.rb defining all 3 attacks
Code: Implement alternating hand strikes in multi-strike patterns
Code: Register in CombatActionCatalog
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber): Add tests/unit/dual_wield_attacks.feature covering dual-wield properties, alternating hand strikes.
Tests (Cucumber Integration): Add integration feature in tests/integration/ for dual-wield attacks in combat.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.

## Metadata - **Commit Message**: `feat(combat): implement 3 dual-wield attack actions` - **Branch**: `feature/m4-dualwield-attacks` ## Background and Context Define 3 dual-wield attacks: Dual Cross, Alternating Flurry, Scissor Cut. These require the :dual_wield configuration and use both hands. ## Expected Behavior All 3 dual-wield attacks defined as CombatActions with multi-strike patterns using both hands. ## Acceptance Criteria - [ ] All 3 dual-wield attacks defined with correct properties - [ ] Equipment requirement: dual_wield configuration - [ ] Multi-strike patterns using alternating hands ## Subtasks - [ ] Code: Create `lib/aethyr/core/combat/actions/dual_wield.rb` defining all 3 attacks - [ ] Code: Implement alternating hand strikes in multi-strike patterns - [ ] Code: Register in CombatActionCatalog - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber): Add `tests/unit/dual_wield_attacks.feature` covering dual-wield properties, alternating hand strikes. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` for dual-wield attacks in combat. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.

freemo added this to the v1.3.0 milestone

freemo added the

labels

freemo self-assigned this

2026-03-16 01:50:16 +00:00

freemo added a new dependency

2026-03-16 01:53:12 +00:00