Implement two-handed weapon attacks: Heavy Slash, Cleave, Spear Thrust, and 4 more

freemo commented

2026-03-16 01:50:15 +00:00

Owner

Metadata

Commit Message: feat(combat): implement 7 two-handed weapon attack actions
Branch: feature/m4-twohanded-attacks

Background and Context

Define all 7 two-handed attacks: Heavy Slash R, Heavy Overhead, Sweep Low, Cleave, Pommel Strike, Staff Sweep, Spear Thrust. Two-handed attacks generally have higher damage and wider patterns but higher AP costs and longer delays.

Expected Behavior

All 7 two-handed attacks defined as CombatActions with correct properties per spec. Two-handed attacks require the :two_handed weapon configuration.

Acceptance Criteria

All 7 two-handed attacks defined with correct properties
Equipment requirement: two_handed weapon configuration
Higher base damage than one-handed equivalents
Wider strike patterns

Subtasks

Code: Create lib/aethyr/core/combat/actions/two_handed.rb defining all 7 attacks
Code: Set equipment_requirements to require :two_handed configuration
Code: Register in CombatActionCatalog
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber): Add tests/unit/two_handed_attacks.feature covering each attack properties, equipment requirement validation.
Tests (Cucumber Integration): Add integration feature in tests/integration/ for two-handed attacks in combat.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.

## Metadata - **Commit Message**: `feat(combat): implement 7 two-handed weapon attack actions` - **Branch**: `feature/m4-twohanded-attacks` ## Background and Context Define all 7 two-handed attacks: Heavy Slash R, Heavy Overhead, Sweep Low, Cleave, Pommel Strike, Staff Sweep, Spear Thrust. Two-handed attacks generally have higher damage and wider patterns but higher AP costs and longer delays. ## Expected Behavior All 7 two-handed attacks defined as CombatActions with correct properties per spec. Two-handed attacks require the :two_handed weapon configuration. ## Acceptance Criteria - [ ] All 7 two-handed attacks defined with correct properties - [ ] Equipment requirement: two_handed weapon configuration - [ ] Higher base damage than one-handed equivalents - [ ] Wider strike patterns ## Subtasks - [ ] Code: Create `lib/aethyr/core/combat/actions/two_handed.rb` defining all 7 attacks - [ ] Code: Set equipment_requirements to require :two_handed configuration - [ ] Code: Register in CombatActionCatalog - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber): Add `tests/unit/two_handed_attacks.feature` covering each attack properties, equipment requirement validation. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` for two-handed attacks in combat. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.