Implement one-handed weapon attacks: Quick Slash, Overhead Strike, Cross Slash, and 9 more

freemo commented

2026-03-16 01:50:15 +00:00

Owner

Metadata

Commit Message: feat(combat): implement 12 one-handed weapon attack actions
Branch: feature/m4-onehanded-attacks

Background and Context

Define all 12 one-handed weapon attacks as CombatAction instances: Quick Slash R, Quick Slash L, Quick Thrust, Slash R, Slash L, Overhead Strike, Rising Cut, Cross Slash, Lunging Thrust, Whirlwind, Feint, Backstab, Axe Rend, Mace Crush. Each has unique AP cost, delay, strikes pattern, damage, and momentum.

Expected Behavior

A registry of one-handed attack CombatActions is loaded from configuration. Each action has all 19 properties defined per specification §16.

Acceptance Criteria

All 12 one-handed attacks defined with correct properties
Each attack has unique strike patterns on the body grid
AP costs range from 1-3 as specified
Delay values match specification (0-2 rounds)
Actions registered in the combat action catalog

Subtasks

Code: Create lib/aethyr/core/combat/actions/one_handed.rb defining all 12 attacks
Code: Define strike patterns, AP costs, delays, damage values per specification
Code: Register all actions in the CombatActionCatalog
Code: Add skill requirements (Swordplay level thresholds)
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber): Add tests/unit/one_handed_attacks.feature covering each attack has correct properties, pattern projection, validation.
Tests (Cucumber Integration): Add integration feature in tests/integration/ for one-handed attacks executing in combat.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.

## Metadata - **Commit Message**: `feat(combat): implement 12 one-handed weapon attack actions` - **Branch**: `feature/m4-onehanded-attacks` ## Background and Context Define all 12 one-handed weapon attacks as CombatAction instances: Quick Slash R, Quick Slash L, Quick Thrust, Slash R, Slash L, Overhead Strike, Rising Cut, Cross Slash, Lunging Thrust, Whirlwind, Feint, Backstab, Axe Rend, Mace Crush. Each has unique AP cost, delay, strikes pattern, damage, and momentum. ## Expected Behavior A registry of one-handed attack CombatActions is loaded from configuration. Each action has all 19 properties defined per specification §16. ## Acceptance Criteria - [ ] All 12 one-handed attacks defined with correct properties - [ ] Each attack has unique strike patterns on the body grid - [ ] AP costs range from 1-3 as specified - [ ] Delay values match specification (0-2 rounds) - [ ] Actions registered in the combat action catalog ## Subtasks - [ ] Code: Create `lib/aethyr/core/combat/actions/one_handed.rb` defining all 12 attacks - [ ] Code: Define strike patterns, AP costs, delays, damage values per specification - [ ] Code: Register all actions in the CombatActionCatalog - [ ] Code: Add skill requirements (Swordplay level thresholds) - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber): Add `tests/unit/one_handed_attacks.feature` covering each attack has correct properties, pattern projection, validation. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` for one-handed attacks executing in combat. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.