Implement full combat resolution algorithm: shield sweep, attacks, damage application

## Metadata - **Commit Message**: `feat(combat): implement full combat resolution algorithm` - **Branch**: `feature/m4-combat-resolution` ## Background and Context The combat resolution algorithm is the core of the deterministic combat system. It processes all committed actions in order: 1) Resolve shield sweeps to determine blocked cells, 2) Resolve attacks checking each strike against blocked cells, 3) Apply damage to body parts, 4) Update hand positions and grid state. The algorithm is fully deterministic — identical inputs always produce identical outputs. ## Expected Behavior CombatResolver takes a round's committed actions and produces a complete resolution result: all damage dealt, blocks, misses, kills, disabilities, and position updates. ## Acceptance Criteria - [ ] Resolution order: shields first, then attacks by AP cost (lower first) - [ ] Shield sweeps generate blocked cell sets - [ ] Attack strikes checked against blocked cells - [ ] Damage applied to body parts with armor mitigation - [ ] Deterministic: same inputs always produce same outputs - [ ] Resolution result contains all events for combat log - [ ] Hand positions updated to final offsets ## Subtasks - [ ] Code: Create `lib/aethyr/core/combat/combat_resolver.rb` with CombatResolver class - [ ] Code: Implement `resolve(round_actions)` as the main entry point - [ ] Code: Phase 1: Collect and resolve all shield actions, build blocked_cells set - [ ] Code: Phase 2: Sort attack actions by priority, resolve strikes against blocked_cells - [ ] Code: Phase 3: Apply damage to BodyParts, check for kills and disabilities - [ ] Code: Phase 4: Update hand positions, publish Wisper events for all outcomes - [ ] Code: Return CombatResolutionResult with detailed event log - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber): Add `tests/unit/combat_resolution.feature` covering full resolution with shields+attacks, determinism verification (same input=same output), damage application, kill/disable triggers. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` for full combat round resolution between two combatants. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.

freemo commented

2026-03-16 01:50:13 +00:00

Owner

Metadata

Commit Message: feat(combat): implement full combat resolution algorithm
Branch: feature/m4-combat-resolution

Background and Context

The combat resolution algorithm is the core of the deterministic combat system. It processes all committed actions in order: 1) Resolve shield sweeps to determine blocked cells, 2) Resolve attacks checking each strike against blocked cells, 3) Apply damage to body parts, 4) Update hand positions and grid state. The algorithm is fully deterministic — identical inputs always produce identical outputs.

Expected Behavior

CombatResolver takes a round's committed actions and produces a complete resolution result: all damage dealt, blocks, misses, kills, disabilities, and position updates.

Acceptance Criteria

Resolution order: shields first, then attacks by AP cost (lower first)
Shield sweeps generate blocked cell sets
Attack strikes checked against blocked cells
Damage applied to body parts with armor mitigation
Deterministic: same inputs always produce same outputs
Resolution result contains all events for combat log
Hand positions updated to final offsets

Subtasks

Code: Create lib/aethyr/core/combat/combat_resolver.rb with CombatResolver class
Code: Implement resolve(round_actions) as the main entry point
Code: Phase 1: Collect and resolve all shield actions, build blocked_cells set
Code: Phase 2: Sort attack actions by priority, resolve strikes against blocked_cells
Code: Phase 3: Apply damage to BodyParts, check for kills and disabilities
Code: Phase 4: Update hand positions, publish Wisper events for all outcomes
Code: Return CombatResolutionResult with detailed event log
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber): Add tests/unit/combat_resolution.feature covering full resolution with shields+attacks, determinism verification (same input=same output), damage application, kill/disable triggers.
Tests (Cucumber Integration): Add integration feature in tests/integration/ for full combat round resolution between two combatants.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.