#271 - Implement shield sweep blocking — shield traces path and blocks intersecting strikes - aethyr/Aethyr

freemo commented

2026-03-16 01:50:13 +00:00

Owner

Metadata

Commit Message: feat(combat): implement shield sweep blocking system
Branch: feature/m4-shield-sweep

Background and Context

Shield actions trace a path across the body grid. Any attack strike that targets a cell along the shield's path is blocked. Shield sweeps are resolved BEFORE attacks in the Resolution phase. The shield's path is defined by its pattern (array of cells it covers).

Expected Behavior

Shield sweep actions define a path of cells. During resolution, the shield path is calculated first. Then each attack strike is checked against the shield path. If a strike's target cell is on the shield path, it is blocked.

Acceptance Criteria

Shield sweep defines a path of grid cells
Shield resolution occurs before attack resolution
Attack strikes targeting cells on the shield path are blocked
Shield can block multiple strikes if they target cells along the path
Shield position updates to final position after sweep

Subtasks

Code: Implement resolve_shields(shield_actions) returning a set of covered cells
Code: Calculate shield path from starting position through pattern offsets
Code: Modify attack resolution to check each strike against covered cells set
Code: Ensure shield resolution runs before attack resolution in the Resolution phase
Code: Update shield hand position to final offset after sweep
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber): Add tests/unit/shield_sweep.feature covering shield path calculation, strike interception, multi-strike blocking, shield-before-attack ordering.
Tests (Cucumber Integration): Add integration feature in tests/integration/ for shield blocking attacks in combat.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.

## Metadata - **Commit Message**: `feat(combat): implement shield sweep blocking system` - **Branch**: `feature/m4-shield-sweep` ## Background and Context Shield actions trace a path across the body grid. Any attack strike that targets a cell along the shield's path is blocked. Shield sweeps are resolved BEFORE attacks in the Resolution phase. The shield's path is defined by its pattern (array of cells it covers). ## Expected Behavior Shield sweep actions define a path of cells. During resolution, the shield path is calculated first. Then each attack strike is checked against the shield path. If a strike's target cell is on the shield path, it is blocked. ## Acceptance Criteria - [ ] Shield sweep defines a path of grid cells - [ ] Shield resolution occurs before attack resolution - [ ] Attack strikes targeting cells on the shield path are blocked - [ ] Shield can block multiple strikes if they target cells along the path - [ ] Shield position updates to final position after sweep ## Subtasks - [ ] Code: Implement `resolve_shields(shield_actions)` returning a set of covered cells - [ ] Code: Calculate shield path from starting position through pattern offsets - [ ] Code: Modify attack resolution to check each strike against covered cells set - [ ] Code: Ensure shield resolution runs before attack resolution in the Resolution phase - [ ] Code: Update shield hand position to final offset after sweep - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber): Add `tests/unit/shield_sweep.feature` covering shield path calculation, strike interception, multi-strike blocking, shield-before-attack ordering. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` for shield blocking attacks in combat. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.