Implement multi-strike system with sustained and interrupted momentum types

freemo commented

2026-03-16 01:50:13 +00:00

Owner

Metadata

Commit Message: feat(combat): implement multi-strike momentum system
Branch: feature/m4-multi-strike

Background and Context

Some actions have multiple strikes (array of target cells hit sequentially). The momentum type determines what happens when a strike is blocked: Sustained means blocked strikes deal 0 damage but the arc continues to subsequent strikes. Interrupted means a blocked strike cancels all remaining strikes in the sequence.

Expected Behavior

The resolution engine processes each strike in order. For each strike, it checks if a block/shield covers that cell. If blocked and momentum is :sustained, the strike deals 0 but continues. If blocked and :interrupted, remaining strikes are cancelled.

Acceptance Criteria

Multi-strike actions process strikes in array order
Blocked strike with :sustained momentum deals 0 damage, continues to next strike
Blocked strike with :interrupted momentum cancels all subsequent strikes
Unblocked strikes deal full damage to the target body part
Each strike generates its own damage event

Subtasks

Code: Implement resolve_strikes(action, defender_blocks) in combat resolution
Code: Handle :sustained momentum — continue arc after block
Code: Handle :interrupted momentum — cancel remaining strikes on block
Code: Generate per-strike damage events with hit/blocked/cancelled status
Code: Return strike results array for combat log display
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber): Add tests/unit/multi_strike.feature covering sustained arc continuation, interrupted cancellation, unblocked damage.
Tests (Cucumber Integration): Add integration feature in tests/integration/ for multi-strike action resolution in combat.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.

## Metadata - **Commit Message**: `feat(combat): implement multi-strike momentum system` - **Branch**: `feature/m4-multi-strike` ## Background and Context Some actions have multiple strikes (array of target cells hit sequentially). The momentum type determines what happens when a strike is blocked: Sustained means blocked strikes deal 0 damage but the arc continues to subsequent strikes. Interrupted means a blocked strike cancels all remaining strikes in the sequence. ## Expected Behavior The resolution engine processes each strike in order. For each strike, it checks if a block/shield covers that cell. If blocked and momentum is :sustained, the strike deals 0 but continues. If blocked and :interrupted, remaining strikes are cancelled. ## Acceptance Criteria - [ ] Multi-strike actions process strikes in array order - [ ] Blocked strike with :sustained momentum deals 0 damage, continues to next strike - [ ] Blocked strike with :interrupted momentum cancels all subsequent strikes - [ ] Unblocked strikes deal full damage to the target body part - [ ] Each strike generates its own damage event ## Subtasks - [ ] Code: Implement `resolve_strikes(action, defender_blocks)` in combat resolution - [ ] Code: Handle :sustained momentum — continue arc after block - [ ] Code: Handle :interrupted momentum — cancel remaining strikes on block - [ ] Code: Generate per-strike damage events with hit/blocked/cancelled status - [ ] Code: Return strike results array for combat log display - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber): Add `tests/unit/multi_strike.feature` covering sustained arc continuation, interrupted cancellation, unblocked damage. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` for multi-strike action resolution in combat. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.