Implement delayed action queue with round countdown and automatic execution #267

Open
opened 2026-03-16 01:50:11 +00:00 by freemo · 0 comments
Owner

Metadata

  • Commit Message: feat(combat): implement delayed action queue with countdown execution
  • Branch: feature/m4-delayed-queue

Background and Context

The delayed action queue stores all committed actions that have delay>0. Each round during the Countdown phase, all queued actions have their remaining delay decremented. When an action reaches delay=0, it is moved to the Resolution queue for execution in the next Resolution phase.

Expected Behavior

DelayedActionQueue manages a priority-ordered list of pending actions. Methods: enqueue(action), tick() (decrement all), ready_actions() (return and remove delay=0 actions), all_pending().

Acceptance Criteria

  • Actions are enqueued with their delay value
  • tick() decrements all pending actions by 1
  • ready_actions() returns actions that have reached delay=0
  • Returned ready actions are removed from the queue
  • Queue maintains order by original submission time

Subtasks

  • Code: Create lib/aethyr/core/combat/delayed_action_queue.rb
  • Code: Implement enqueue(action) adding to pending list
  • Code: Implement tick() decrementing remaining_delay on all entries
  • Code: Implement ready_actions() extracting and returning delay=0 actions
  • Code: Implement all_pending() for telegraph display
  • Code: Integrate with TurnManager Countdown and Resolution phases
  • Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
  • Tests (Cucumber): Add tests/unit/delayed_queue.feature covering enqueue, tick decrement, ready extraction, order preservation.
  • Tests (Cucumber Integration): Add integration feature in tests/integration/ for delayed queue across multiple combat rounds.
  • Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
  • Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
  • Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

  • All subtasks above are completed and checked off.
  • A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
  • The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
  • The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.
## Metadata - **Commit Message**: `feat(combat): implement delayed action queue with countdown execution` - **Branch**: `feature/m4-delayed-queue` ## Background and Context The delayed action queue stores all committed actions that have delay>0. Each round during the Countdown phase, all queued actions have their remaining delay decremented. When an action reaches delay=0, it is moved to the Resolution queue for execution in the next Resolution phase. ## Expected Behavior DelayedActionQueue manages a priority-ordered list of pending actions. Methods: `enqueue(action)`, `tick()` (decrement all), `ready_actions()` (return and remove delay=0 actions), `all_pending()`. ## Acceptance Criteria - [ ] Actions are enqueued with their delay value - [ ] `tick()` decrements all pending actions by 1 - [ ] `ready_actions()` returns actions that have reached delay=0 - [ ] Returned ready actions are removed from the queue - [ ] Queue maintains order by original submission time ## Subtasks - [ ] Code: Create `lib/aethyr/core/combat/delayed_action_queue.rb` - [ ] Code: Implement `enqueue(action)` adding to pending list - [ ] Code: Implement `tick()` decrementing remaining_delay on all entries - [ ] Code: Implement `ready_actions()` extracting and returning delay=0 actions - [ ] Code: Implement `all_pending()` for telegraph display - [ ] Code: Integrate with TurnManager Countdown and Resolution phases - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber): Add `tests/unit/delayed_queue.feature` covering enqueue, tick decrement, ready extraction, order preservation. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` for delayed queue across multiple combat rounds. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.
freemo added this to the v1.3.0 milestone 2026-03-16 01:50:11 +00:00
freemo self-assigned this 2026-03-16 01:50:11 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference: aethyr/Aethyr#267
No description provided.