Implement action delay property (0-4+ rounds) on combat action data model

## Metadata - **Commit Message**: `feat(combat): implement action delay property for telegraph system` - **Branch**: `feature/m4-action-delay` ## Background and Context Combat actions have a delay property (0 = immediate, 1-4+ = delayed by that many rounds). Delayed actions are queued and execute automatically when their countdown reaches 0. This creates strategic depth as opponents can see and react to incoming delayed actions. ## Expected Behavior Each CombatAction has a `delay` integer property. Actions with delay=0 execute in the current round's Resolution phase. Actions with delay>0 are added to the delayed action queue and decrement each round during the Countdown phase. ## Acceptance Criteria - [ ] CombatAction has `delay` property (integer, 0-4+) - [ ] delay=0 actions execute immediately in Resolution phase - [ ] delay>0 actions enter the delayed queue - [ ] Delayed actions decrement each round in Countdown phase - [ ] delay=0 triggers execution in Resolution phase ## Subtasks - [ ] Code: Add `delay` property to CombatAction data model with default 0 - [ ] Code: Implement delayed action queue in TurnManager — `pending_actions` array - [ ] Code: In Countdown phase, decrement all pending actions' remaining delay - [ ] Code: Move actions reaching delay=0 from pending to Resolution execution queue - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber): Add `tests/unit/action_delay.feature` covering immediate action execution, delayed action queuing, countdown decrement, delayed execution. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` for delayed action resolving after correct number of rounds. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.

freemo commented

2026-03-16 01:50:11 +00:00

Owner

Metadata

Commit Message: feat(combat): implement action delay property for telegraph system
Branch: feature/m4-action-delay

Background and Context

Combat actions have a delay property (0 = immediate, 1-4+ = delayed by that many rounds). Delayed actions are queued and execute automatically when their countdown reaches 0. This creates strategic depth as opponents can see and react to incoming delayed actions.

Expected Behavior

Each CombatAction has a delay integer property. Actions with delay=0 execute in the current round's Resolution phase. Actions with delay>0 are added to the delayed action queue and decrement each round during the Countdown phase.

Acceptance Criteria

CombatAction has delay property (integer, 0-4+)
delay=0 actions execute immediately in Resolution phase
delay>0 actions enter the delayed queue
Delayed actions decrement each round in Countdown phase
delay=0 triggers execution in Resolution phase

Subtasks

Code: Add delay property to CombatAction data model with default 0
Code: Implement delayed action queue in TurnManager — pending_actions array
Code: In Countdown phase, decrement all pending actions' remaining delay
Code: Move actions reaching delay=0 from pending to Resolution execution queue
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber): Add tests/unit/action_delay.feature covering immediate action execution, delayed action queuing, countdown decrement, delayed execution.
Tests (Cucumber Integration): Add integration feature in tests/integration/ for delayed action resolving after correct number of rounds.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.