Implement asynchronous turn submission with configurable 60-second timer

## Metadata - **Commit Message**: `feat(combat): implement async turn submission with timer` - **Branch**: `feature/m4-async-turns` ## Background and Context In an MMO context, players need time to plan their turns. A configurable timer (default 60 seconds) allows asynchronous submission. If a player doesn't submit by the deadline, their turn is auto-submitted with a default defensive action. ## Expected Behavior TurnTimer manages per-combatant submission deadlines. When the timer expires, a default action (stance-appropriate block or dodge) is auto-submitted. NPCs submit immediately based on AI. ## Acceptance Criteria - [ ] Configurable timer per combat instance (default 60s) - [ ] Timer starts at beginning of Planning phase - [ ] Manual submission cancels the timer - [ ] Timeout auto-submits a default defensive action - [ ] NPC combatants submit immediately via AI ## Subtasks - [ ] Code: Create `lib/aethyr/core/combat/turn_timer.rb` with TurnTimer class - [ ] Code: Implement timer using Concurrent::ScheduledTask for non-blocking countdown - [ ] Code: Implement auto-submit on timeout with default defensive action selection - [ ] Code: Implement manual submit cancellation of timer - [ ] Code: Add timer configuration to config.yaml under combat section - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber): Add `tests/unit/async_turns.feature` covering turn timer expiry, auto-submit on timeout, timer cancellation on manual submit. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` for turn timer behavior in live combat. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.

freemo commented

2026-03-16 01:50:10 +00:00

Owner

Metadata

Commit Message: feat(combat): implement async turn submission with timer
Branch: feature/m4-async-turns

Background and Context

In an MMO context, players need time to plan their turns. A configurable timer (default 60 seconds) allows asynchronous submission. If a player doesn't submit by the deadline, their turn is auto-submitted with a default defensive action.

Expected Behavior

TurnTimer manages per-combatant submission deadlines. When the timer expires, a default action (stance-appropriate block or dodge) is auto-submitted. NPCs submit immediately based on AI.

Acceptance Criteria

Configurable timer per combat instance (default 60s)
Timer starts at beginning of Planning phase
Manual submission cancels the timer
Timeout auto-submits a default defensive action
NPC combatants submit immediately via AI

Subtasks

Code: Create lib/aethyr/core/combat/turn_timer.rb with TurnTimer class
Code: Implement timer using Concurrent::ScheduledTask for non-blocking countdown
Code: Implement auto-submit on timeout with default defensive action selection
Code: Implement manual submit cancellation of timer
Code: Add timer configuration to config.yaml under combat section
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber): Add tests/unit/async_turns.feature covering turn timer expiry, auto-submit on timeout, timer cancellation on manual submit.
Tests (Cucumber Integration): Add integration feature in tests/integration/ for turn timer behavior in live combat.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.