Implement 5-phase turn cycle: Planning, Commit, Resolution, Countdown, Grid Update

## Metadata - **Commit Message**: `feat(combat): implement 5-phase turn cycle` - **Branch**: `feature/m4-turn-phases` ## Background and Context Each combat round proceeds through 5 phases: Planning (players select actions), Commit (actions are locked in), Resolution (actions execute in order), Countdown (delayed actions tick down), Grid Update (positions and states update). ## Expected Behavior TurnManager advances through phases in order. Each phase has entry/exit hooks. The Planning phase accepts action selections. The Commit phase locks selections. Resolution executes immediate actions. Countdown decrements delayed action timers. Grid Update applies position changes. ## Acceptance Criteria - [ ] TurnManager cycles through 5 phases in correct order - [ ] Planning phase accepts action submissions from combatants - [ ] Commit phase locks in actions and rejects further changes - [ ] Resolution phase executes actions in priority order - [ ] Countdown phase decrements delayed action timers - [ ] Grid Update phase applies final position changes and state updates - [ ] Phase transitions publish Wisper events ## Subtasks - [ ] Code: Create `lib/aethyr/core/combat/turn_manager.rb` with TurnManager class - [ ] Code: Implement phase state machine with 5 states and transitions - [ ] Code: Implement Planning phase — collect action selections, validate against AP budget - [ ] Code: Implement Commit phase — freeze action list, reject modifications - [ ] Code: Implement Resolution phase — sort actions by priority, execute sequentially - [ ] Code: Implement Countdown phase — decrement delay counters on pending actions - [ ] Code: Implement Grid Update phase — apply position offsets, update hand tracker, reset AP - [ ] Code: Publish phase transition events via Wisper - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber): Add `tests/unit/turn_phases.feature` covering 5 phase transitions, phase-appropriate actions, phase timeout. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` for full turn cycle in a 2-combatant fight. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.

freemo commented

2026-03-16 01:50:09 +00:00

Owner

Metadata

Commit Message: feat(combat): implement 5-phase turn cycle
Branch: feature/m4-turn-phases

Background and Context

Each combat round proceeds through 5 phases: Planning (players select actions), Commit (actions are locked in), Resolution (actions execute in order), Countdown (delayed actions tick down), Grid Update (positions and states update).

Expected Behavior

TurnManager advances through phases in order. Each phase has entry/exit hooks. The Planning phase accepts action selections. The Commit phase locks selections. Resolution executes immediate actions. Countdown decrements delayed action timers. Grid Update applies position changes.

Acceptance Criteria

TurnManager cycles through 5 phases in correct order
Planning phase accepts action submissions from combatants
Commit phase locks in actions and rejects further changes
Resolution phase executes actions in priority order
Countdown phase decrements delayed action timers
Grid Update phase applies final position changes and state updates
Phase transitions publish Wisper events

Subtasks

Code: Create lib/aethyr/core/combat/turn_manager.rb with TurnManager class
Code: Implement phase state machine with 5 states and transitions
Code: Implement Planning phase — collect action selections, validate against AP budget
Code: Implement Commit phase — freeze action list, reject modifications
Code: Implement Resolution phase — sort actions by priority, execute sequentially
Code: Implement Countdown phase — decrement delay counters on pending actions
Code: Implement Grid Update phase — apply position offsets, update hand tracker, reset AP
Code: Publish phase transition events via Wisper
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber): Add tests/unit/turn_phases.feature covering 5 phase transitions, phase-appropriate actions, phase timeout.
Tests (Cucumber Integration): Add integration feature in tests/integration/ for full turn cycle in a 2-combatant fight.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.