Implement ActionPoint budget system with 3 AP/turn default and per-turn regeneration

## Metadata - **Commit Message**: `feat(combat): implement ActionPoint budget system` - **Branch**: `feature/m4-action-points` ## Background and Context Each combatant has an action point (AP) budget per turn, defaulting to 3 AP. Actions cost varying amounts of AP. Unused AP does not carry over. AP regenerates fully at the start of each turn. ## Expected Behavior ActionPointTracker manages per-combatant AP. Methods: `spend(cost)` (returns false if insufficient), `remaining()`, `reset()` (called at turn start), `max_ap()`. AP can be modified by equipment or status effects. ## Acceptance Criteria - [ ] Default AP budget is 3 per turn - [ ] `spend(cost)` deducts AP and returns true, or returns false if insufficient - [ ] `reset()` restores AP to max at turn start - [ ] AP cannot go negative - [ ] Equipment/status modifiers can increase or decrease max_ap ## Subtasks - [ ] Code: Create `lib/aethyr/core/combat/action_point_tracker.rb` - [ ] Code: Implement `spend(cost)`, `remaining`, `reset`, `max_ap` methods - [ ] Code: Add modifier system for equipment/status effects on max_ap - [ ] Code: Publish `:ap_spent` Wisper event on each spend - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber): Add `tests/unit/action_points.feature` covering AP budget initialization, spending, regeneration, over-budget rejection. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` for AP tracking across multiple combat rounds. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.

freemo commented

2026-03-16 01:50:09 +00:00

Owner

Metadata

Commit Message: feat(combat): implement ActionPoint budget system
Branch: feature/m4-action-points

Background and Context

Each combatant has an action point (AP) budget per turn, defaulting to 3 AP. Actions cost varying amounts of AP. Unused AP does not carry over. AP regenerates fully at the start of each turn.

Expected Behavior

ActionPointTracker manages per-combatant AP. Methods: spend(cost) (returns false if insufficient), remaining(), reset() (called at turn start), max_ap(). AP can be modified by equipment or status effects.

Acceptance Criteria

Default AP budget is 3 per turn
spend(cost) deducts AP and returns true, or returns false if insufficient
reset() restores AP to max at turn start
AP cannot go negative
Equipment/status modifiers can increase or decrease max_ap

Subtasks

Code: Create lib/aethyr/core/combat/action_point_tracker.rb
Code: Implement spend(cost), remaining, reset, max_ap methods
Code: Add modifier system for equipment/status effects on max_ap
Code: Publish :ap_spent Wisper event on each spend
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber): Add tests/unit/action_points.feature covering AP budget initialization, spending, regeneration, over-budget rejection.
Tests (Cucumber Integration): Add integration feature in tests/integration/ for AP tracking across multiple combat rounds.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.