Implement HandTracker with 7 weapon configurations and starting positions

## Metadata - **Commit Message**: `feat(combat): implement HandTracker with 7 weapon configurations` - **Branch**: `feature/m4-hand-tracker` ## Background and Context The combat system tracks what each hand holds and its position on the body grid. There are 7 weapon configurations: weapon+shield, dual-wield, two-handed, weapon+free, shield+free, unarmed, staff/polearm. Each configuration determines starting hand positions and available actions. ## Expected Behavior HandTracker class manages left_hand and right_hand state. Each hand has: held_item (weapon/shield/nil), position (grid cell), and available_actions (based on configuration). Starting positions depend on configuration and current stance. ## Acceptance Criteria - [ ] HandTracker detects one of 7 configurations from equipped items - [ ] Each configuration sets correct starting hand positions on the grid - [ ] Hand positions update after each action (based on action's final_offset) - [ ] `available_actions(hand)` returns only actions valid for current configuration - [ ] Configuration changes when equipment changes mid-combat ## Subtasks - [ ] Code: Create `lib/aethyr/core/combat/hand_tracker.rb` with HandTracker class - [ ] Code: Define 7 configuration types as constants with starting positions and valid action sets - [ ] Code: Implement `detect_configuration(player)` that examines equipment to determine config - [ ] Code: Implement `update_position(hand, new_row, new_col)` for post-action position updates - [ ] Code: Implement `available_actions(hand)` filtering by current configuration - [ ] Code: Implement `reset_positions(stance)` to return hands to starting positions for current stance - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber): Add `tests/unit/hand_tracker.feature` covering 7 weapon configurations, starting positions, hand state transitions. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` for hand tracking initialization when combat starts. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.

freemo commented

2026-03-16 01:50:08 +00:00

Owner

Metadata

Commit Message: feat(combat): implement HandTracker with 7 weapon configurations
Branch: feature/m4-hand-tracker

Background and Context

The combat system tracks what each hand holds and its position on the body grid. There are 7 weapon configurations: weapon+shield, dual-wield, two-handed, weapon+free, shield+free, unarmed, staff/polearm. Each configuration determines starting hand positions and available actions.

Expected Behavior

HandTracker class manages left_hand and right_hand state. Each hand has: held_item (weapon/shield/nil), position (grid cell), and available_actions (based on configuration). Starting positions depend on configuration and current stance.

Acceptance Criteria

HandTracker detects one of 7 configurations from equipped items
Each configuration sets correct starting hand positions on the grid
Hand positions update after each action (based on action's final_offset)
available_actions(hand) returns only actions valid for current configuration
Configuration changes when equipment changes mid-combat

Subtasks

Code: Create lib/aethyr/core/combat/hand_tracker.rb with HandTracker class
Code: Define 7 configuration types as constants with starting positions and valid action sets
Code: Implement detect_configuration(player) that examines equipment to determine config
Code: Implement update_position(hand, new_row, new_col) for post-action position updates
Code: Implement available_actions(hand) filtering by current configuration
Code: Implement reset_positions(stance) to return hands to starting positions for current stance
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber): Add tests/unit/hand_tracker.feature covering 7 weapon configurations, starting positions, hand state transitions.
Tests (Cucumber Integration): Add integration feature in tests/integration/ for hand tracking initialization when combat starts.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.