Implement BodyPart data model with individual HP pools and lethal zone flags

## Metadata - **Commit Message**: `feat(combat): implement BodyPart data model with HP pools and lethal zones` - **Branch**: `feature/m4-body-part` ## Background and Context Each of the 16 body parts on the combat grid has its own HP pool and properties. Four parts are designated as lethal zones (Head, Neck, Chest, Torso) — reducing their HP to zero is fatal. Other parts can be disabled without killing the character. ## Expected Behavior A BodyPart class tracks name, max_hp, current_hp, lethal flag, disabled flag, and armor_value. Methods support damage application, healing, status queries, and disability checks. ## Acceptance Criteria - [ ] BodyPart stores name, max_hp, current_hp, lethal?, disabled?, armor_value - [ ] `take_damage(amount, type)` reduces HP after armor mitigation - [ ] Reaching 0 HP on a lethal part triggers :combatant_killed event - [ ] Reaching 0 HP on a non-lethal part sets disabled=true and triggers :limb_disabled event - [ ] 16 body parts defined: Head, Neck, L.Shoulder, R.Shoulder, Chest, L.Upper Arm, R.Upper Arm, Torso, L.Forearm, R.Forearm, L.Hand, R.Hand, L.Thigh, R.Thigh, L.Shin, R.Shin ## Subtasks - [ ] Code: Create `lib/aethyr/core/combat/body_part.rb` with BodyPart class - [ ] Code: Define the 16 body parts with default HP values and lethal zone flags - [ ] Code: Implement `take_damage(amount, damage_type)` with armor mitigation (damage = max(0, amount - armor_value)) - [ ] Code: Implement lethal check — publish `:combatant_killed` via Wisper when lethal part reaches 0 HP - [ ] Code: Implement disability — set `disabled=true` and publish `:limb_disabled` when non-lethal part reaches 0 HP - [ ] Code: Implement `heal(amount)` capped at max_hp - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber): Add `tests/unit/body_part.feature` covering body part creation, HP pools, lethal zone flags, damage application. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` for body part damage during combat resolution. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.

freemo commented

2026-03-16 01:50:06 +00:00

Owner

Metadata

Commit Message: feat(combat): implement BodyPart data model with HP pools and lethal zones
Branch: feature/m4-body-part

Background and Context

Each of the 16 body parts on the combat grid has its own HP pool and properties. Four parts are designated as lethal zones (Head, Neck, Chest, Torso) — reducing their HP to zero is fatal. Other parts can be disabled without killing the character.

Expected Behavior

A BodyPart class tracks name, max_hp, current_hp, lethal flag, disabled flag, and armor_value. Methods support damage application, healing, status queries, and disability checks.

Acceptance Criteria

BodyPart stores name, max_hp, current_hp, lethal?, disabled?, armor_value
take_damage(amount, type) reduces HP after armor mitigation
Reaching 0 HP on a lethal part triggers :combatant_killed event
Reaching 0 HP on a non-lethal part sets disabled=true and triggers :limb_disabled event
16 body parts defined: Head, Neck, L.Shoulder, R.Shoulder, Chest, L.Upper Arm, R.Upper Arm, Torso, L.Forearm, R.Forearm, L.Hand, R.Hand, L.Thigh, R.Thigh, L.Shin, R.Shin

Subtasks

Code: Create lib/aethyr/core/combat/body_part.rb with BodyPart class
Code: Define the 16 body parts with default HP values and lethal zone flags
Code: Implement take_damage(amount, damage_type) with armor mitigation (damage = max(0, amount - armor_value))
Code: Implement lethal check — publish :combatant_killed via Wisper when lethal part reaches 0 HP
Code: Implement disability — set disabled=true and publish :limb_disabled when non-lethal part reaches 0 HP
Code: Implement heal(amount) capped at max_hp
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber): Add tests/unit/body_part.feature covering body part creation, HP pools, lethal zone flags, damage application.
Tests (Cucumber Integration): Add integration feature in tests/integration/ for body part damage during combat resolution.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.