Remove hardcoded extension requires from login.rb and player.rb

## Metadata - **Commit Message**: `refactor(extensions): remove hardcoded extension requires` - **Branch**: `feature/m3-extension-scanner` ## Background and Context `login.rb:282-283` directly requires `extensions/objects/clothing_items` and `extensions/objects/sword`. `player.rb:5-6` directly requires extension skills. Both have TODO comments to remove these hardcoded requires. Extension loading should be handled entirely by the ExtensionScanner auto-discovery mechanism. ## Expected Behavior All hardcoded extension require statements are removed from `login.rb` and `player.rb`. Extension loading is handled by ExtensionScanner. The server starts correctly with all extensions loaded via auto-discovery. ## Acceptance Criteria - [ ] `login.rb` hardcoded extension requires (lines 281-283 TODO + requires) removed - [ ] `player.rb` hardcoded extension requires (lines 4-6 TODO + requires) removed - [ ] Extension loading handled by ExtensionScanner call instead of hardcoded requires - [ ] Server starts correctly with all extensions loaded via auto-discovery ## Subtasks - [ ] Code: Identify and remove hardcoded require statements for extension files in `login.rb` - [ ] Code: Identify and remove hardcoded require statements for extension files in `player.rb` - [ ] Code: Replace removed requires with ExtensionScanner call if not already present - [ ] Docs: Update extension loading documentation if applicable - [ ] Tests (Cucumber): Add `tests/unit/extension_scanner.feature` covering auto-discovery loading, removal of hardcoded requires, and extension availability. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` for extension auto-discovery and server startup. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions for extension loading. - [ ] Quality: Verify coverage >=85% via `bundle exec rake unit`. If coverage is <85% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=85%. Only mark this as complete once coverage is >=85%, if not repeat this task as many times as is needed until coverage reaches >=85%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.

freemo commented

2026-03-14 23:57:28 +00:00

Owner

Metadata

Commit Message: refactor(extensions): remove hardcoded extension requires
Branch: feature/m3-extension-scanner

Background and Context

login.rb:282-283 directly requires extensions/objects/clothing_items and extensions/objects/sword. player.rb:5-6 directly requires extension skills. Both have TODO comments to remove these hardcoded requires. Extension loading should be handled entirely by the ExtensionScanner auto-discovery mechanism.

Expected Behavior

All hardcoded extension require statements are removed from login.rb and player.rb. Extension loading is handled by ExtensionScanner. The server starts correctly with all extensions loaded via auto-discovery.

Acceptance Criteria

login.rb hardcoded extension requires (lines 281-283 TODO + requires) removed
player.rb hardcoded extension requires (lines 4-6 TODO + requires) removed
Extension loading handled by ExtensionScanner call instead of hardcoded requires
Server starts correctly with all extensions loaded via auto-discovery

Subtasks

Code: Identify and remove hardcoded require statements for extension files in login.rb
Code: Identify and remove hardcoded require statements for extension files in player.rb
Code: Replace removed requires with ExtensionScanner call if not already present
Docs: Update extension loading documentation if applicable
Tests (Cucumber): Add tests/unit/extension_scanner.feature covering auto-discovery loading, removal of hardcoded requires, and extension availability.
Tests (Cucumber Integration): Add integration feature in tests/integration/ for extension auto-discovery and server startup.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions for extension loading.
Quality: Verify coverage >=85% via bundle exec rake unit. If coverage is <85% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=85%. Only mark this as complete once coverage is >=85%, if not repeat this task as many times as is needed until coverage reaches >=85%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.