Fix execute permissions on bin/aethyr_experiments #72

Open
opened 2026-03-14 23:57:27 +00:00 by freemo · 0 comments
Owner

Metadata

  • Commit Message: fix(experiments): fix execute permissions on bin/aethyr_experiments
  • Branch: feature/m3-experiments-perms

Background and Context

bin/aethyr_experiments has permissions 644 (not executable), unlike bin/aethyr and bin/aethyr_setup which are 755. This prevents the script from being run directly from the command line.

Expected Behavior

bin/aethyr_experiments has execute permission (755) matching other bin scripts, and its shebang line is correct for direct execution.

Acceptance Criteria

  • File permission is 755 (matching bin/aethyr and bin/aethyr_setup)
  • Shebang line is correct and present
  • git diff shows the permission change

Subtasks

  • Code: chmod +x bin/aethyr_experiments
  • Code: Verify shebang line is correct
  • Docs: No documentation changes needed for this fix
  • Tests (Cucumber): Add tests/unit/bin_permissions.feature covering executable permission validation for bin scripts.
  • Tests (Cucumber Integration): Add integration feature in tests/integration/ for bin script execution verification.
  • Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions for bin script execution.
  • Quality: Verify coverage >=85% via bundle exec rake unit. If coverage is <85% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=85%. Only mark this as complete once coverage is >=85%, if not repeat this task as many times as is needed until coverage reaches >=85%.
  • Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

  • All subtasks above are completed and checked off.
  • A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
  • The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
  • The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.
## Metadata - **Commit Message**: `fix(experiments): fix execute permissions on bin/aethyr_experiments` - **Branch**: `feature/m3-experiments-perms` ## Background and Context `bin/aethyr_experiments` has permissions 644 (not executable), unlike `bin/aethyr` and `bin/aethyr_setup` which are 755. This prevents the script from being run directly from the command line. ## Expected Behavior `bin/aethyr_experiments` has execute permission (755) matching other bin scripts, and its shebang line is correct for direct execution. ## Acceptance Criteria - [ ] File permission is 755 (matching `bin/aethyr` and `bin/aethyr_setup`) - [ ] Shebang line is correct and present - [ ] `git diff` shows the permission change ## Subtasks - [ ] Code: `chmod +x bin/aethyr_experiments` - [ ] Code: Verify shebang line is correct - [ ] Docs: No documentation changes needed for this fix - [ ] Tests (Cucumber): Add `tests/unit/bin_permissions.feature` covering executable permission validation for bin scripts. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` for bin script execution verification. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions for bin script execution. - [ ] Quality: Verify coverage >=85% via `bundle exec rake unit`. If coverage is <85% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=85%. Only mark this as complete once coverage is >=85%, if not repeat this task as many times as is needed until coverage reaches >=85%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.
freemo added this to the v1.1.0 milestone 2026-03-14 23:57:27 +00:00
freemo self-assigned this 2026-03-15 04:25:23 +00:00
freemo modified the milestone from v1.1.0 to v1.2.0 2026-03-16 00:28:13 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference: aethyr/Aethyr#72
No description provided.