Enforce coordinates/mapping when moving room's area

## Metadata - **Commit Message**: `fix(area): enforce coordinate constraints when moving rooms between areas` - **Branch**: `feature/m3-enforce-coords-area-move` ## Background and Context When a room is moved from one area to another (e.g., via `aput` or area reassignment), the room's coordinates from the source area may not be valid in the target area's coordinate system. This can result in overlapping rooms or invalid grid positions in `:world` mapped areas. ## Expected Behavior When moving a room to a different area, clear or remap the room's coordinates to be valid within the target area's mapping type and coordinate system. Warn the administrator if coordinate conflicts would arise. ## Acceptance Criteria - [ ] Moving a room to a new area clears stale coordinates from the source area - [ ] For `:world` mapped target areas, assign valid coordinates or prompt for them - [ ] No coordinate conflicts or overlaps result from the move - [ ] Map display updates correctly in both source and target areas ## Subtasks - [ ] Code: Identify the code path where rooms are moved between areas - [ ] Code: Clear the room's old coordinates when removed from the source area - [ ] Code: For `:world` mapped target areas, validate or assign coordinates in the target grid - [ ] Code: Add warning/error messages when coordinate conflicts would occur - [ ] Docs: Update YARD comments on area room management methods - [ ] Tests (Cucumber): Add `tests/unit/room_area_move.feature` covering: move between areas, coordinate clearing, world-mapped target validation - [ ] Tests (Cucumber Integration): Add integration feature verifying room movement between areas. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.

freemo commented

2018-09-22 17:56:52 +00:00

(Migrated from git.qoto.org)

Metadata

Commit Message: fix(area): enforce coordinate constraints when moving rooms between areas
Branch: feature/m3-enforce-coords-area-move

Background and Context

When a room is moved from one area to another (e.g., via aput or area reassignment), the room's coordinates from the source area may not be valid in the target area's coordinate system. This can result in overlapping rooms or invalid grid positions in :world mapped areas.

Expected Behavior

When moving a room to a different area, clear or remap the room's coordinates to be valid within the target area's mapping type and coordinate system. Warn the administrator if coordinate conflicts would arise.

Acceptance Criteria

Moving a room to a new area clears stale coordinates from the source area
For :world mapped target areas, assign valid coordinates or prompt for them
No coordinate conflicts or overlaps result from the move
Map display updates correctly in both source and target areas

Subtasks

Code: Identify the code path where rooms are moved between areas
Code: Clear the room's old coordinates when removed from the source area
Code: For :world mapped target areas, validate or assign coordinates in the target grid
Code: Add warning/error messages when coordinate conflicts would occur
Docs: Update YARD comments on area room management methods
Tests (Cucumber): Add tests/unit/room_area_move.feature covering: move between areas, coordinate clearing, world-mapped target validation
Tests (Cucumber Integration): Add integration feature verifying room movement between areas.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.