Fix thread-local flavour_cache memoization to ensure room description diversity #59

New issue

Open

opened 2026-03-14 23:57:24 +00:00 by freemo · 0 comments

freemo commented

2026-03-14 23:57:24 +00:00

Owner

Metadata

Commit Message: fix(worldgen): remove thread-local flavour_cache memoization for unique room descriptions
Branch: feature/m3-v11-fix-flavour-cache

Background

flavour_cache uses ||= per thread per terrain, so every room of a terrain type in a thread gets the same description.

Expected Behavior

Each room gets an independent random sample from its terrain's description pool.

Acceptance Criteria

Thread-local flavour_cache memoization removed
Each room samples independently from the description pool
Consecutive rooms of the same terrain have different descriptions (probabilistically)

Subtasks

Replace flavour_cache with per-room random sampling
Tests: Unit test verifying two consecutive rooms have different descriptions
Run bundle exec rake unit, fix any errors

Definition of Done

This issue is complete when all subtasks are done, commit created on the specified branch, PR submitted and merged.

## Metadata - **Commit Message**: `fix(worldgen): remove thread-local flavour_cache memoization for unique room descriptions` - **Branch**: `feature/m3-v11-fix-flavour-cache` ## Background `flavour_cache` uses `||=` per thread per terrain, so every room of a terrain type in a thread gets the same description. ## Expected Behavior Each room gets an independent random sample from its terrain's description pool. ## Acceptance Criteria - [ ] Thread-local `flavour_cache` memoization removed - [ ] Each room samples independently from the description pool - [ ] Consecutive rooms of the same terrain have different descriptions (probabilistically) ## Subtasks - [ ] Replace `flavour_cache` with per-room random sampling - [ ] Tests: Unit test verifying two consecutive rooms have different descriptions - [ ] Run `bundle exec rake unit`, fix any errors ## Definition of Done This issue is complete when all subtasks are done, commit created on the specified branch, PR submitted and merged.