Update ESA code-to-terrain mapping in world cover generator

## Metadata - **Commit Message**: `feat(worldgen): update ESA code-to-terrain mapping` - **Branch**: `feature/m3-terrain-types` ## Background and Context The world cover generator in `lib/aethyr/core/util/world_cover_generator.rb` maps ESA WorldCover GeoTIFF pixel values to terrain types. With the addition of FOREST, OCEAN, and DESERT terrain types (issue #52), the generator's mapping table must be updated to use these new types instead of defaulting everything to GRASSLAND. ## Expected Behavior The world cover generator maps ESA codes to terrain types per the specification: - 10 (tree cover) → FOREST - 20 (shrubland) → FOREST - 30 (grassland), 40 (cropland), 90 (herbaceous wetland), 95 (mangroves) → GRASSLAND - 50 (built-up) → CITY - 60 (bare/sparse vegetation) → DESERT - 70 (snow and ice), 100 (moss and lichen) → TUNDRA - 80 (permanent water bodies) → OCEAN ## Acceptance Criteria - [ ] Generator maps ESA codes 10, 20 to FOREST terrain - [ ] Generator maps ESA code 60 to DESERT terrain - [ ] Generator maps ESA code 80 to OCEAN terrain - [ ] All other existing mappings remain correct - [ ] Generated rooms have the correct terrain type based on satellite data ## Subtasks - [ ] Code: Locate the ESA code-to-terrain mapping in `lib/aethyr/core/util/world_cover_generator.rb` - [ ] Code: Update the mapping hash/case to assign codes 10, 20 to FOREST (requires FOREST constant from #52) - [ ] Code: Update the mapping to assign code 60 to DESERT - [ ] Code: Update the mapping to assign code 80 to OCEAN - [ ] Code: Verify codes 30, 40, 90, 95 still map to GRASSLAND; code 50 to CITY; codes 70, 100 to TUNDRA - [ ] Docs: Update RDoc comments on the generator's mapping method - [ ] Tests (Cucumber): Add `tests/unit/world_cover_mapping.feature` covering: each ESA code maps to the correct terrain type, unknown codes have a sensible default - [ ] Tests (Cucumber Integration): Add integration feature verifying rooms generated from WorldCover data have correct terrain types - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions in world generation - [ ] Quality: Verify coverage >=85% via `bundle exec rake unit`. If coverage is <85% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=85%. Only mark this as complete once coverage is >=85%, if not repeat this task as many times as is needed until coverage reaches >=85%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.

freemo commented

2026-03-14 23:57:23 +00:00

Owner

Metadata

Commit Message: feat(worldgen): update ESA code-to-terrain mapping
Branch: feature/m3-terrain-types

Background and Context

The world cover generator in lib/aethyr/core/util/world_cover_generator.rb maps ESA WorldCover GeoTIFF pixel values to terrain types. With the addition of FOREST, OCEAN, and DESERT terrain types (issue #52), the generator's mapping table must be updated to use these new types instead of defaulting everything to GRASSLAND.

Expected Behavior

The world cover generator maps ESA codes to terrain types per the specification:

10 (tree cover) → FOREST
20 (shrubland) → FOREST
30 (grassland), 40 (cropland), 90 (herbaceous wetland), 95 (mangroves) → GRASSLAND
50 (built-up) → CITY
60 (bare/sparse vegetation) → DESERT
70 (snow and ice), 100 (moss and lichen) → TUNDRA
80 (permanent water bodies) → OCEAN

Acceptance Criteria

Generator maps ESA codes 10, 20 to FOREST terrain
Generator maps ESA code 60 to DESERT terrain
Generator maps ESA code 80 to OCEAN terrain
All other existing mappings remain correct
Generated rooms have the correct terrain type based on satellite data

Subtasks

Code: Locate the ESA code-to-terrain mapping in lib/aethyr/core/util/world_cover_generator.rb
Code: Update the mapping hash/case to assign codes 10, 20 to FOREST (requires FOREST constant from #52)
Code: Update the mapping to assign code 60 to DESERT
Code: Update the mapping to assign code 80 to OCEAN
Code: Verify codes 30, 40, 90, 95 still map to GRASSLAND; code 50 to CITY; codes 70, 100 to TUNDRA
Docs: Update RDoc comments on the generator's mapping method
Tests (Cucumber): Add tests/unit/world_cover_mapping.feature covering: each ESA code maps to the correct terrain type, unknown codes have a sensible default
Tests (Cucumber Integration): Add integration feature verifying rooms generated from WorldCover data have correct terrain types
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions in world generation
Quality: Verify coverage >=85% via bundle exec rake unit. If coverage is <85% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=85%. Only mark this as complete once coverage is >=85%, if not repeat this task as many times as is needed until coverage reaches >=85%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.