Allow to delete coordinates of room

## Metadata - **Commit Message**: `feat(room): allow deletion of room coordinates via admin command` - **Branch**: `feature/m3-delete-room-coords` ## Background and Context Rooms in areas with `:world` mapping have grid coordinates that determine their position on the map. Currently there is no way for an administrator to clear or delete a room's coordinates, which is needed when reorganizing rooms or changing mapping types. ## Expected Behavior An admin command (e.g., `aset room:coords none` or similar) allows removing a room's coordinates. After removal, the room still exists but is not placed on the area's grid map until new coordinates are assigned. ## Acceptance Criteria - [ ] Administrator can delete/clear a room's coordinates - [ ] Room remains functional (accessible via exits) after coordinate removal - [ ] Map display correctly excludes rooms without coordinates - [ ] Coordinates can be reassigned after deletion ## Subtasks - [ ] Code: Add coordinate deletion support to `HandleAset` when targeting room coordinates - [ ] Code: Modify the Area map rendering to skip rooms with nil/empty coordinates - [ ] Code: Ensure room exits and navigation remain functional without coordinates - [ ] Docs: Update YARD comments on Room coordinate methods and `aset.help` - [ ] Tests (Cucumber): Add `tests/unit/room_coord_delete.feature` covering: coordinate deletion, map rendering without coords, coordinate reassignment - [ ] Tests (Cucumber Integration): Add integration feature verifying coordinate deletion and map behavior. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.

freemo commented

2018-09-22 17:56:10 +00:00

(Migrated from git.qoto.org)

Metadata

Commit Message: feat(room): allow deletion of room coordinates via admin command
Branch: feature/m3-delete-room-coords

Background and Context

Rooms in areas with :world mapping have grid coordinates that determine their position on the map. Currently there is no way for an administrator to clear or delete a room's coordinates, which is needed when reorganizing rooms or changing mapping types.

Expected Behavior

An admin command (e.g., aset room:coords none or similar) allows removing a room's coordinates. After removal, the room still exists but is not placed on the area's grid map until new coordinates are assigned.

Acceptance Criteria

Administrator can delete/clear a room's coordinates
Room remains functional (accessible via exits) after coordinate removal
Map display correctly excludes rooms without coordinates
Coordinates can be reassigned after deletion

Subtasks

Code: Add coordinate deletion support to HandleAset when targeting room coordinates
Code: Modify the Area map rendering to skip rooms with nil/empty coordinates
Code: Ensure room exits and navigation remain functional without coordinates
Docs: Update YARD comments on Room coordinate methods and aset.help
Tests (Cucumber): Add tests/unit/room_coord_delete.feature covering: coordinate deletion, map rendering without coords, coordinate reassignment
Tests (Cucumber Integration): Add integration feature verifying coordinate deletion and map behavior.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.