Emit attribute update events from combat damage #43

Open
opened 2026-03-14 23:54:58 +00:00 by freemo · 0 comments
Owner

Metadata

  • Commit Message: feat(event-sourcing): emit attribute events from combat damage processing
  • Branch: feature/m1-v12-combat-events

Background

Combat actions modify health via take_damage but do not emit GameObjectAttributeUpdated events.

Expected Behavior

When event sourcing is enabled, LivingObject#take_damage emits UpdateGameObjectAttribute commands for health changes.

Acceptance Criteria

  • take_damage emits attribute update events for health stat changes
  • Events guarded by event_sourcing_enabled check

Subtasks

  • Add event emission to LivingObject#take_damage or via info.stats.health setter
  • Tests: Unit tests verifying events on damage
  • Run bundle exec rake unit, fix any errors

Definition of Done

This issue is complete when all subtasks are done, commit created on the specified branch, PR submitted and merged.

## Metadata - **Commit Message**: `feat(event-sourcing): emit attribute events from combat damage processing` - **Branch**: `feature/m1-v12-combat-events` ## Background Combat actions modify health via `take_damage` but do not emit `GameObjectAttributeUpdated` events. ## Expected Behavior When event sourcing is enabled, `LivingObject#take_damage` emits `UpdateGameObjectAttribute` commands for health changes. ## Acceptance Criteria - [ ] `take_damage` emits attribute update events for health stat changes - [ ] Events guarded by `event_sourcing_enabled` check ## Subtasks - [ ] Add event emission to `LivingObject#take_damage` or via `info.stats.health` setter - [ ] Tests: Unit tests verifying events on damage - [ ] Run `bundle exec rake unit`, fix any errors ## Definition of Done This issue is complete when all subtasks are done, commit created on the specified branch, PR submitted and merged.
freemo added this to the v1.2.0 milestone 2026-03-14 23:54:58 +00:00
freemo self-assigned this 2026-03-15 04:25:22 +00:00
freemo modified the milestone from v1.2.0 to v1.0.0 2026-03-15 23:19:36 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference: aethyr/Aethyr#43
No description provided.