Enforce mapping type when deleting exits

## Metadata - **Commit Message**: `fix(area): enforce mapping type constraints when deleting exits` - **Branch**: `feature/m3-enforce-mapping-exit-delete` ## Background and Context When deleting exits, the system does not consider the impact on the area's mapping type constraints. For `:world` mapping areas, deleting certain exits could break grid connectivity assumptions. The system should warn or prevent deletion of exits that would violate mapping type invariants. ## Expected Behavior When deleting an exit in a `:world` mapped area, warn the administrator if the deletion would break grid adjacency. For `:rooms` and `:none` mapped areas, allow unrestricted deletion. ## Acceptance Criteria - [ ] Exit deletion in `:world` mapped areas warns about grid connectivity impact - [ ] Exit deletion in `:rooms` and `:none` areas works without additional checks - [ ] Administrator can override the warning with a force flag ## Subtasks - [ ] Code: Add mapping type check to exit deletion logic in the appropriate admin command handler - [ ] Code: For `:world` mapping, check if deleting the exit breaks grid adjacency and issue a warning - [ ] Code: Add a `--force` or confirmation mechanism to override the warning - [ ] Docs: Update YARD comments and help file for the exit deletion command - [ ] Tests (Cucumber): Add `tests/unit/exit_delete_mapping.feature` covering: normal deletion, world mapping warning, force override - [ ] Tests (Cucumber Integration): Add integration feature verifying exit deletion behavior with mapping constraints. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.

freemo commented

2018-09-22 17:55:04 +00:00

(Migrated from git.qoto.org)

Metadata

Commit Message: fix(area): enforce mapping type constraints when deleting exits
Branch: feature/m3-enforce-mapping-exit-delete

Background and Context

When deleting exits, the system does not consider the impact on the area's mapping type constraints. For :world mapping areas, deleting certain exits could break grid connectivity assumptions. The system should warn or prevent deletion of exits that would violate mapping type invariants.

Expected Behavior

When deleting an exit in a :world mapped area, warn the administrator if the deletion would break grid adjacency. For :rooms and :none mapped areas, allow unrestricted deletion.

Acceptance Criteria

Exit deletion in :world mapped areas warns about grid connectivity impact
Exit deletion in :rooms and :none areas works without additional checks
Administrator can override the warning with a force flag

Subtasks

Code: Add mapping type check to exit deletion logic in the appropriate admin command handler
Code: For :world mapping, check if deleting the exit breaks grid adjacency and issue a warning
Code: Add a --force or confirmation mechanism to override the warning
Docs: Update YARD comments and help file for the exit deletion command
Tests (Cucumber): Add tests/unit/exit_delete_mapping.feature covering: normal deletion, world mapping warning, force override
Tests (Cucumber Integration): Add integration feature verifying exit deletion behavior with mapping constraints.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.