Fix player object belonging to area instead of room

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: aethyr/Aethyr#336

freemo commented

2026-03-31 03:28:00 +00:00

Owner

Metadata

Key	Value
Branch	`master`
Commit Message	`fix: fixed player belonging to area instead of room`
Parent Epic	#312 — Core Trait Bug Fixes

Background and Context

Player objects were being incorrectly assigned to the area-level container instead of the
room they should inhabit. This caused players to be invisible to other room occupants and
broke room-scoped commands like look, say, and movement.

Expected Behavior

When a player enters the game or changes rooms, their container reference points to the
room object, not the area object. Room-scoped commands work correctly.

Acceptance Criteria

Player's container is the room, not the area.
Room look shows the player to other occupants.
Room-scoped communication commands work correctly.

Subtasks

Code

Code: Fix the object hierarchy so players are placed in rooms, not areas.

Quality

Docs: No documentation changes required (bug fix only).
Tests (Cucumber): Existing player/room tests pass.
Tests (Cucumber Integration): Existing integration tests pass.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit.
Quality: Run bundle exec rake and bundle exec rake integration, fix any errors.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
Commit c633a044 on master (2026-03-30) resolves this issue.
Retroactive issue — this bug was fixed before the issue was created.

## Metadata | Key | Value | |-----|-------| | **Branch** | `master` | | **Commit Message** | `fix: fixed player belonging to area instead of room` | | **Parent Epic** | #312 — Core Trait Bug Fixes | ## Background and Context Player objects were being incorrectly assigned to the area-level container instead of the room they should inhabit. This caused players to be invisible to other room occupants and broke room-scoped commands like `look`, `say`, and movement. ## Expected Behavior When a player enters the game or changes rooms, their container reference points to the room object, not the area object. Room-scoped commands work correctly. ## Acceptance Criteria - [x] Player's container is the room, not the area. - [x] Room `look` shows the player to other occupants. - [x] Room-scoped communication commands work correctly. ## Subtasks ### Code - [x] Code: Fix the object hierarchy so players are placed in rooms, not areas. ### Quality - [x] Docs: No documentation changes required (bug fix only). - [x] Tests (Cucumber): Existing player/room tests pass. - [x] Tests (Cucumber Integration): Existing integration tests pass. - [x] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [x] Quality: Verify coverage >=97% via `bundle exec rake unit`. - [x] Quality: Run `bundle exec rake` and `bundle exec rake integration`, fix any errors. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - Commit `c633a044` on `master` (2026-03-30) resolves this issue. - **Retroactive issue** — this bug was fixed before the issue was created.

freemo added this to the v1.2.0 milestone

freemo added the

labels

freemo self-assigned this

freemo closed this issue

2026-03-31 03:28:02 +00:00