Implement RenderOp data model and core RenderOp types #304
Labels
No labels
Blocked
Duplicate
MoSCoW/Could Have
MoSCoW/Must Have
MoSCoW/Should Have
Points/1
Points/13
Points/2
Points/21
Points/3
Points/5
Points/8
Priority/Backlog
Priority/Critical
Priority/High
Priority/Low
Priority/Medium
State/Completed
State/In progress
State/In review
State/Paused
State/Unverified
State/Verified
State/Wont Do
Type/Bug
Type/Epic
Type/Feature
Type/Legendary
Type/Task
Type/Testing
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Blocks
#302 Epic: Event Projection System
aethyr/Aethyr
Reference: aethyr/Aethyr#304
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Metadata
feature/m2-render-opsfeat: implement RenderOp data model and core RenderOp typesBackground and Context
RenderOps are the currency of the render pipeline — they describe what needs to be rendered without specifying how. Each RenderOp is a simple, immutable value object carrying a type, a target window, and type-specific data. The render pipeline consumes these ops and translates them into actual terminal output.
Expected Behavior
RenderOpis a value object (frozen after creation) with:type— one of 7 core typeswindow— target window identifier (:main,:status,:map,:prompt,:chat, etc.)data— a hash of type-specific dataCore RenderOp types:
:text_append— Append text to a window. Data:{ text:, style: }:map_refresh— Refresh the map display. Data:{ map_data: }:bar_update— Update a status bar. Data:{ bar:, value:, max: }:prompt_update— Update the prompt line. Data:{ text: }:window_clear— Clear a window's content. Data:{}:overlay_show— Show an overlay/modal. Data:{ content:, title: }:overlay_hide— Hide the current overlay. Data:{}Factory methods for convenience:
Acceptance Criteria
RenderOpis an immutable value object (frozen after creation).:text_append,:map_refresh,:bar_update,:prompt_update,:window_clear,:overlay_show,:overlay_hide.RenderOp#type,#window, and#dataaccessors are available.Subtasks
Code
RenderOpvalue object class withtype,window,dataattributes..text_append,.map_refresh,.bar_update,.prompt_update,.window_clear,.overlay_show,.overlay_hide.#==and#hashfor equality comparison.Quality
tests/unit/render_ops.featurecovering creating each of the 7 RenderOp types via factory methods, immutability verification, data validation for required fields, equality comparison, invalid type rejection, accessing type/window/data.tests/integration/for RenderOp value objects flowing through the render pipeline.bundle exec rake unit_profileand verify no performance regressions.bundle exec rake unit. If coverage is <97% then review the current unit test coverage report atbuild/tests/unit/coverage/and use it to write new Cucumber based unit tests to improve coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerunbundle exec rake unitto verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.bundle exec rake(default task: unit tests with coverage) andbundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.Definition of Done
This issue is complete when:
master, reviewed, and merged before this issue is marked done.Implementation Notes
Implemented the RenderOp data model as specified. Key design decisions:
Architecture
RenderOp.text_append()) that validates required fields before construction.#==,#eql?, and#hashso RenderOps can be used as hash keys and compared for equality.Validation
ArgumentErrorat construction timenilwindow is explicitly rejectedTesting
render_op.rbPR