Replace player.output() in communication, info, settings, and meta commands

freemo commented

2026-03-15 23:08:52 +00:00

Owner

Metadata

Commit Message: refactor(events): replace player.output() in communication, info, settings, and meta commands
Branch: feature/m1-sunset-output-comms-info

Background and Context

Communication, info/utility, settings, and meta commands use player.output().

Acceptance Criteria

All player.output() in listed commands replaced
All affected tests pass

Subtasks

Replace in communication commands (say, whisper, tell)
Replace in info/utility commands (who, time, date, health, satiety, skills, status, help)
Replace in settings commands (set, gait, pose)
Replace in meta commands (quit, deleteme, issue)
Tests (Cucumber): Verify output unchanged
Run bundle exec rake unit, fix any failures
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber Integration): Add integration feature in tests/integration/ verifying communication, info, settings, and meta commands produce output via Wisper.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when all subtasks are completed, commit created with prescribed message on prescribed branch, PR submitted, reviewed, and merged.

## Metadata - **Commit Message:** `refactor(events): replace player.output() in communication, info, settings, and meta commands` - **Branch:** `feature/m1-sunset-output-comms-info` ## Background and Context Communication, info/utility, settings, and meta commands use `player.output()`. ## Acceptance Criteria - All `player.output()` in listed commands replaced - All affected tests pass ## Subtasks - [ ] Replace in communication commands (say, whisper, tell) - [ ] Replace in info/utility commands (who, time, date, health, satiety, skills, status, help) - [ ] Replace in settings commands (set, gait, pose) - [ ] Replace in meta commands (quit, deleteme, issue) - [ ] Tests (Cucumber): Verify output unchanged - [ ] Run `bundle exec rake unit`, fix any failures - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` verifying communication, info, settings, and meta commands produce output via Wisper. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when all subtasks are completed, commit created with prescribed message on prescribed branch, PR submitted, reviewed, and merged.