Replace room.output() calls with Wisper events and delete Container#output

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks

#182 Epic: Sunset Legacy room.output() Pattern

aethyr/Aethyr

Reference: aethyr/Aethyr#183

freemo commented

2026-03-15 23:08:50 +00:00

Owner

Metadata

Commit Message: refactor(events): replace room.output() with Wisper events and delete Container#output
Branch: feature/m1-sunset-room-output

Background and Context

Container#output (lines 50-56 of container.rb) iterates inventory and calls .output(message) on each object. Called from Manager (2 sites), emote.rb, sit.rb, and editor.rb.

Acceptance Criteria

All 5 call sites replaced with Wisper room broadcasts
Temporary subscriber on Player for backward compat during transition
Container#output deleted
All tests pass

Subtasks

Create temporary :room_broadcast subscriber on Player
Replace room.output() in Manager (2 sites)
Replace room.output() in emote.rb
Replace room.output() in sit.rb
Replace room.output() in editor.rb
Delete Container#output method
Tests (Cucumber): Verify room-wide messages reach players
Run bundle exec rake unit, fix any failures
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber Integration): Add integration feature in tests/integration/ verifying room-level output routes through Wisper events; Container#output is deleted.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.

## Metadata - **Commit Message:** `refactor(events): replace room.output() with Wisper events and delete Container#output` - **Branch:** `feature/m1-sunset-room-output` ## Background and Context `Container#output` (lines 50-56 of `container.rb`) iterates inventory and calls `.output(message)` on each object. Called from Manager (2 sites), `emote.rb`, `sit.rb`, and `editor.rb`. ## Acceptance Criteria - All 5 call sites replaced with Wisper room broadcasts - Temporary subscriber on Player for backward compat during transition - `Container#output` deleted - All tests pass ## Subtasks - [ ] Create temporary `:room_broadcast` subscriber on Player - [ ] Replace `room.output()` in Manager (2 sites) - [ ] Replace `room.output()` in `emote.rb` - [ ] Replace `room.output()` in `sit.rb` - [ ] Replace `room.output()` in `editor.rb` - [ ] Delete `Container#output` method - [ ] Tests (Cucumber): Verify room-wide messages reach players - [ ] Run `bundle exec rake unit`, fix any failures - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` verifying room-level output routes through Wisper events; Container#output is deleted. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.

freemo added the

Type/Task

Priority/Medium

State/Unverified

labels

freemo added a new dependency

2026-03-15 23:10:24 +00:00