Replace out_event() in inventory and equipment commands with Wisper events

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks

#178 Epic: Sunset Legacy out_event() Pattern

aethyr/Aethyr

#181 Replace remaining out_event() calls and delete Container#out_event

aethyr/Aethyr

Reference: aethyr/Aethyr#180

freemo commented

2026-03-15 23:08:48 +00:00

Owner

Metadata

Commit Message: refactor(events): replace out_event() with Wisper events in inventory and equipment commands
Branch: feature/m1-sunset-out-event-inventory

Background and Context

Inventory (get.rb, drop.rb, put.rb, give.rb) and equipment (wear.rb, wield.rb, remove.rb, unwield.rb) commands use out_event() for room notifications.

Acceptance Criteria

out_event() calls removed from all listed commands
Replaced with :object_taken, :object_dropped, :equipment_changed events
All affected command tests pass

Subtasks

Replace out_event() in get.rb and drop.rb
Replace out_event() in put.rb and give.rb
Replace out_event() in wear.rb, wield.rb, remove.rb, unwield.rb
Tests (Cucumber): Verify inventory operation output unchanged
Run bundle exec rake unit, fix any failures
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber Integration): Add integration feature in tests/integration/ verifying inventory commands produce correct output via Wisper events instead of out_event.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.

## Metadata - **Commit Message:** `refactor(events): replace out_event() with Wisper events in inventory and equipment commands` - **Branch:** `feature/m1-sunset-out-event-inventory` ## Background and Context Inventory (`get.rb`, `drop.rb`, `put.rb`, `give.rb`) and equipment (`wear.rb`, `wield.rb`, `remove.rb`, `unwield.rb`) commands use `out_event()` for room notifications. ## Acceptance Criteria - `out_event()` calls removed from all listed commands - Replaced with `:object_taken`, `:object_dropped`, `:equipment_changed` events - All affected command tests pass ## Subtasks - [ ] Replace `out_event()` in `get.rb` and `drop.rb` - [ ] Replace `out_event()` in `put.rb` and `give.rb` - [ ] Replace `out_event()` in `wear.rb`, `wield.rb`, `remove.rb`, `unwield.rb` - [ ] Tests (Cucumber): Verify inventory operation output unchanged - [ ] Run `bundle exec rake unit`, fix any failures - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` verifying inventory commands produce correct output via Wisper events instead of out_event. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.

freemo added the

Type/Task

Priority/Medium

State/Unverified

labels

freemo added a new dependency

2026-03-15 23:10:24 +00:00

2026-03-15 23:10:30 +00:00