Define and publish object interaction and skill Wisper events

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks

#172 Epic: Core Domain Event Definitions

aethyr/Aethyr

Reference: aethyr/Aethyr#177

freemo commented

2026-03-15 23:08:46 +00:00

Owner

Metadata

Commit Message: feat(events): publish object interaction, equipment, inventory, and skill events
Branch: feature/m1-interaction-skill-events

Background and Context

Object interactions, equipment changes, inventory changes, and skill XP gains happen via direct method calls. The spec defines events for each.

Acceptance Criteria

:object_dropped and :object_taken from get/drop
:equipment_changed from wear/wield/remove/unwield
:inventory_changed from inventory operations
:skill_xp_gained from skill XP
:stance_changed from sit/stand

Subtasks

Add :object_dropped and :object_taken broadcasts
Add :equipment_changed in equipment operations
Add :inventory_changed in inventory operations
Add :skill_xp_gained in skill XP logic
Add :stance_changed in position changes
Tests (Cucumber): Scenarios for each event type
Run bundle exec rake unit, fix any failures
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber Integration): Add integration feature in tests/integration/ verifying object interaction events fire for get, drop, and use actions.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.

## Metadata - **Commit Message:** `feat(events): publish object interaction, equipment, inventory, and skill events` - **Branch:** `feature/m1-interaction-skill-events` ## Background and Context Object interactions, equipment changes, inventory changes, and skill XP gains happen via direct method calls. The spec defines events for each. ## Acceptance Criteria - `:object_dropped` and `:object_taken` from get/drop - `:equipment_changed` from wear/wield/remove/unwield - `:inventory_changed` from inventory operations - `:skill_xp_gained` from skill XP - `:stance_changed` from sit/stand ## Subtasks - [ ] Add `:object_dropped` and `:object_taken` broadcasts - [ ] Add `:equipment_changed` in equipment operations - [ ] Add `:inventory_changed` in inventory operations - [ ] Add `:skill_xp_gained` in skill XP logic - [ ] Add `:stance_changed` in position changes - [ ] Tests (Cucumber): Scenarios for each event type - [ ] Run `bundle exec rake unit`, fix any failures - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` verifying object interaction events fire for get, drop, and use actions. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.

freemo added the

State/Unverified

Type/Feature

Priority/Medium

labels

freemo added a new dependency

2026-03-15 23:10:23 +00:00