Define and publish calendar and session Wisper events

## Metadata - **Commit Message:** `feat(events): publish calendar time and player session Wisper events` - **Branch:** `feature/m1-calendar-session-events` ## Background and Context Calendar atmospheric messages use direct `player.output()`. Player connect/disconnect is handled internally. The spec defines `:time_advanced`, `:atmosphere_message`, `:dawn`, `:dusk`, `:midnight`, `:player_connected`, `:player_disconnected`, and `:server_announcement`. ## Acceptance Criteria - Calendar broadcasts time-related events on transitions - Manager broadcasts session events on connect/disconnect - Manager broadcasts `:server_announcement` from admin commands ## Subtasks - [ ] Add `:time_advanced` from Calendar on each game-hour tick - [ ] Add `:atmosphere_message` from Calendar atmospheric generation - [ ] Add `:dawn`, `:dusk`, `:midnight` from Calendar at appropriate times - [ ] Add `:player_connected` from Manager on login - [ ] Add `:player_disconnected` from Manager on disconnect - [ ] Add `:server_announcement` from admin broadcast commands - [ ] Tests (Cucumber): Scenarios for calendar events - [ ] Tests (Cucumber): Scenarios for session events - [ ] Run `bundle exec rake unit`, fix any failures - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` verifying calendar events fire when game time advances. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.

freemo commented

2026-03-15 23:08:46 +00:00

Owner

Metadata

Commit Message: feat(events): publish calendar time and player session Wisper events
Branch: feature/m1-calendar-session-events

Background and Context

Calendar atmospheric messages use direct player.output(). Player connect/disconnect is handled internally. The spec defines :time_advanced, :atmosphere_message, :dawn, :dusk, :midnight, :player_connected, :player_disconnected, and :server_announcement.

Acceptance Criteria

Calendar broadcasts time-related events on transitions
Manager broadcasts session events on connect/disconnect
Manager broadcasts :server_announcement from admin commands

Subtasks

Add :time_advanced from Calendar on each game-hour tick
Add :atmosphere_message from Calendar atmospheric generation
Add :dawn, :dusk, :midnight from Calendar at appropriate times
Add :player_connected from Manager on login
Add :player_disconnected from Manager on disconnect
Add :server_announcement from admin broadcast commands
Tests (Cucumber): Scenarios for calendar events
Tests (Cucumber): Scenarios for session events
Run bundle exec rake unit, fix any failures
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber Integration): Add integration feature in tests/integration/ verifying calendar events fire when game time advances.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.