Define and publish room-presence Wisper events

## Metadata - **Commit Message:** `feat(events): publish :entity_entered_room and :entity_left_room Wisper events` - **Branch:** `feature/m1-room-presence-events` ## Background and Context When a player or mobile moves between rooms, no Wisper event is published. The spec defines `:entity_entered_room` and `:entity_left_room` as foundational events that the UI, NPC reactions, and other systems subscribe to. Currently, movement messages are sent via direct `room.out_event()` and `player.output()` calls. ## Acceptance Criteria - Room broadcasts `:entity_entered_room` with `{publisher: room, entity: entity, direction: from_direction}` - Room broadcasts `:entity_left_room` with `{publisher: room, entity: entity, direction: to_direction}` - Both Player and Mobile movements trigger events - Existing movement behavior unchanged (additive events) ## Subtasks - [ ] Add `broadcast(:entity_entered_room, ...)` when entity enters a room - [ ] Add `broadcast(:entity_left_room, ...)` when entity leaves a room - [ ] Ensure events carry entity, direction, and room references - [ ] Tests (Cucumber): Scenario verifying event published on player movement - [ ] Tests (Cucumber): Scenario verifying event published on mobile movement - [ ] Tests (Cucumber): Scenario verifying event payload content - [ ] Run `bundle exec rake unit`, fix any failures - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` verifying room-presence events fire when a player moves between rooms in a live server. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.

freemo commented

2026-03-15 23:08:44 +00:00

Owner

Metadata

Commit Message: feat(events): publish :entity_entered_room and :entity_left_room Wisper events
Branch: feature/m1-room-presence-events

Background and Context

When a player or mobile moves between rooms, no Wisper event is published. The spec defines :entity_entered_room and :entity_left_room as foundational events that the UI, NPC reactions, and other systems subscribe to. Currently, movement messages are sent via direct room.out_event() and player.output() calls.

Acceptance Criteria

Room broadcasts :entity_entered_room with {publisher: room, entity: entity, direction: from_direction}
Room broadcasts :entity_left_room with {publisher: room, entity: entity, direction: to_direction}
Both Player and Mobile movements trigger events
Existing movement behavior unchanged (additive events)

Subtasks

Add broadcast(:entity_entered_room, ...) when entity enters a room
Add broadcast(:entity_left_room, ...) when entity leaves a room
Ensure events carry entity, direction, and room references
Tests (Cucumber): Scenario verifying event published on player movement
Tests (Cucumber): Scenario verifying event published on mobile movement
Tests (Cucumber): Scenario verifying event payload content
Run bundle exec rake unit, fix any failures
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber Integration): Add integration feature in tests/integration/ verifying room-presence events fire when a player moves between rooms in a live server.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.