Implement :es_only write mode and disable GDBM writes #169

New issue

Open

opened 2026-03-15 23:08:40 +00:00 by freemo · 0 comments

freemo commented

2026-03-15 23:08:40 +00:00

Owner

Metadata

Commit Message: feat(event-sourcing): implement es_only write mode, disable GDBM writes
Branch: feature/m4-es-only-mode

Background and Context

In Phase 4, GDBM writes are disabled entirely. The EventSourceService handles all persistence. This is the final step before removing GDBM code.

Acceptance Criteria

:es_only mode skips all GDBM writes
Configuration defaults to :es_only
All game operations work without GDBM

Subtasks

Implement :es_only in EventSourceService (no GDBM interaction)
Update conf/config.yaml default to :es_only
Tests (Cucumber): Full game lifecycle with :es_only mode
Run bundle exec rake unit, fix any failures
Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
Tests (Cucumber Integration): Add integration feature in tests/integration/ verifying ES-only mode persists all game state without GDBM writes.
Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.

## Metadata - **Commit Message:** `feat(event-sourcing): implement es_only write mode, disable GDBM writes` - **Branch:** `feature/m4-es-only-mode` ## Background and Context In Phase 4, GDBM writes are disabled entirely. The `EventSourceService` handles all persistence. This is the final step before removing GDBM code. ## Acceptance Criteria - `:es_only` mode skips all GDBM writes - Configuration defaults to `:es_only` - All game operations work without GDBM ## Subtasks - [ ] Implement `:es_only` in `EventSourceService` (no GDBM interaction) - [ ] Update `conf/config.yaml` default to `:es_only` - [ ] Tests (Cucumber): Full game lifecycle with `:es_only` mode - [ ] Run `bundle exec rake unit`, fix any failures - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` verifying ES-only mode persists all game state without GDBM writes. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.